Review Request 121706: FindMyPhone plugin for KDE Connect

[Apoorv Parle]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/121706/
-----------------------------------------------------------

(Updated Sept. 11, 2015, 7:17 p.m.)


Status
------

This change has been marked as submitted.


Review request for kdeconnect and Albert Vaca Cintora.


Repository: kdeconnect-kde


Description
-------

* FindMyPhone plugin itself.
* Plasmoid updated to include a button to ring the phone.
* Add -ring switch to CLI interface.


Diffs
-----

  cli/kdeconnect-cli.cpp b5336aa663a479345b6a9b27d2faf48ef6db7dad 
  interfaces/CMakeLists.txt 174c65939ff26bb50268a0e8d1a5bf68ed937b10 
  interfaces/dbusinterfaces.h 702d6bb103c64b640cb5a4f6beab56496c6c4de9 
  interfaces/dbusinterfaces.cpp c9b09fd259dbd4a66b4eaff94e16ab651d51c657 
  plasmoid/declarativeplugin/kdeconnectdeclarativeplugin.cpp 0fa00b7b788de8f69962ff9020db37d0fb21f584 
  plasmoid/package/contents/ui/DeviceDelegate.qml 372a1b63eb70ff7fda5ed480d86c1bfa82d6f70f 
  plasmoid/package/contents/ui/FindMyPhone.qml PRE-CREATION 
  plugins/CMakeLists.txt de1131d224c453f86f79c74cb7d720cd8116e1c7 
  plugins/findmyphone/CMakeLists.txt PRE-CREATION 
  plugins/findmyphone/README PRE-CREATION 
  plugins/findmyphone/findmyphoneplugin.h PRE-CREATION 
  plugins/findmyphone/findmyphoneplugin.cpp PRE-CREATION 
  plugins/findmyphone/kdeconnect_findmyphone.desktop PRE-CREATION 

Diff: https://git.reviewboard.kde.org/r/121706/diff/


Testing
-------

* Tested on KDE 4.14.2
* Plugin is non-blocking i.e. other plugins like browse work fine while the phone is ringing.
* Enable/Disable of the plugin has been tested. The button appears/disappears correspondingly.


Thanks,

Apoorv Parle

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdeconnect/attachments/20150911/fbe12cee/attachment.html>