Review Request 125137: Fix make with ninja.

Aleix Pol Gonzalez aleixpol at kde.org
Thu Sep 10 12:04:38 UTC 2015


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125137/#review85107
-----------------------------------------------------------

Ship it!


Ship It!

- Aleix Pol Gonzalez


On Sept. 10, 2015, 2 p.m., Michael Palimaka wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/125137/
> -----------------------------------------------------------
> 
> (Updated Sept. 10, 2015, 2 p.m.)
> 
> 
> Review request for kdeconnect.
> 
> 
> Repository: kdeconnect-kde
> 
> 
> Description
> -------
> 
> The custom command name must differ from the name of the generated file.
> 
> 
> Diffs
> -----
> 
>   cmake/DbusInterfaceMacros.cmake 9d4810d9540f868d6da6869493deec032afced59 
> 
> Diff: https://git.reviewboard.kde.org/r/125137/diff/
> 
> 
> Testing
> -------
> 
> Builds with both ninja and regular make.
> 
> 
> Thanks,
> 
> Michael Palimaka
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdeconnect/attachments/20150910/5589f300/attachment.html>


More information about the KDEConnect mailing list