Review Request 124418: [app] Adjust application name to match desktop file

Martin Gräßlin mgraesslin at kde.org
Mon Sep 7 15:50:42 UTC 2015


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124418/
-----------------------------------------------------------

(Updated Sept. 7, 2015, 3:50 p.m.)


Status
------

This change has been marked as submitted.


Review request for kdeconnect and Aleix Pol Gonzalez.


Changes
-------

Submitted with commit e462c386cf35cd894d6ed9d6a777de65f95e5bd1 by Aleix Pol on behalf of Martin Gräßlin to branch master.


Repository: kdeconnect-kde


Description
-------

The desktop file is called org.kde.kdeconnect.app - this needs to
be respected in the application name. This is a requirement to match
application windows to applications on Wayland. With a not-matching
name the compositor is not able to show a window icon.


Diffs
-----

  app/main.cpp b23bf7055bad69d320aa42598df34d26d620af9d 

Diff: https://git.reviewboard.kde.org/r/124418/diff/


Testing
-------

Window icon shown in e.g. Present Windows. Requires https://codereview.qt-project.org/122045 - this bug made me find and fix a bug in QtWayland :-)


Thanks,

Martin Gräßlin

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdeconnect/attachments/20150907/2089ead1/attachment-0001.html>


More information about the KDEConnect mailing list