Review Request 125086: Add a test for file sending, using the loopbackdevice

[Aleix Pol Gonzalez]

> On Sept. 7, 2015, 12:30 p.m., Albert Vaca Cintora wrote:
> > core/daemon.h, lines 59-60
> > <https://git.reviewboard.kde.org/r/125086/diff/1/?file=402032#file402032line59>
> >
> >     Not implemented!

Yeah, that's unrelated, sorry.


> On Sept. 7, 2015, 12:30 p.m., Albert Vaca Cintora wrote:
> > tests/sendfiletest.cpp, line 88
> > <https://git.reviewboard.kde.org/r/125086/diff/1/?file=402041#file402041line88>
> >
> >     Maybe you could use a cast to SharePlugin instead of using invokeMethod.

We probably don't want to link against it, that's why I didn't.


- Aleix


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125086/#review84944
-----------------------------------------------------------


On Sept. 7, 2015, 11:38 a.m., Aleix Pol Gonzalez wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/125086/
> -----------------------------------------------------------
> 
> (Updated Sept. 7, 2015, 11:38 a.m.)
> 
> 
> Review request for kdeconnect.
> 
> 
> Repository: kdeconnect-kde
> 
> 
> Description
> -------
> 
> Extends unit testing by making sure that file sharing works locally.
> 
> 
> Diffs
> -----
> 
>   core/backends/loopback/loopbackdevicelink.cpp 718c5b8 
>   core/daemon.h d263163 
>   core/daemon.cpp cb6999e 
>   core/device.h 03f528c 
>   core/device.cpp d53b3c5 
>   core/filetransferjob.h 859a303 
>   core/filetransferjob.cpp f503f6a 
>   plugins/share/shareplugin.h de00693 
>   plugins/share/shareplugin.cpp b4331b3 
>   tests/CMakeLists.txt b00a574 
>   tests/sendfiletest.cpp PRE-CREATION 
> 
> Diff: https://git.reviewboard.kde.org/r/125086/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Aleix Pol Gonzalez
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdeconnect/attachments/20150907/fe55db5f/attachment-0001.html>