Review Request 125140: [kdeconnect-kde] initial support for desktop-to-XXX notifications

[Aleix Pol Gonzalez]

> On Nov. 26, 2015, 11:27 p.m., Holger Kaelberer wrote:
> > I've got a follow-up patch adding the kcm bits to allow for configuring what and how to sync notificaitons from desktop. Shall I open a new RR for that or update this RR?
> > Actually I tried opening a new rr, but failed. Maybe because it is built upon a commit-id not yet upstream?

I'd suggest to include it here, this way we can review them both.

And yes, you can't add a patch that depends on something not in git. What you can do is generate the patch against master: `git diff origin/master`

Also maybe it would help to have some screenshots to get an idea.


- Aleix


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125140/#review88882
-----------------------------------------------------------


On Sept. 10, 2015, 5:41 p.m., Holger Kaelberer wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/125140/
> -----------------------------------------------------------
> 
> (Updated Sept. 10, 2015, 5:41 p.m.)
> 
> 
> Review request for kdeconnect.
> 
> 
> Repository: kdeconnect-kde
> 
> 
> Description
> -------
> 
> Eavesdrop on the Notify call of the org.freedesktop.Notifications dbus-interface, proxy all caught notifications to our peer device and track them in the internal notifications-list.
> 
> Also fix "cancel" requests from peer devices, by cutting of kdeconnect-android's id-prefix.
> 
> 
> Diffs
> -----
> 
>   plugins/notifications/CMakeLists.txt 41c5b78 
>   plugins/notifications/notificationsdbusinterface.h e8d5c2a 
>   plugins/notifications/notificationsdbusinterface.cpp e7b89f2 
>   plugins/notifications/notificationslistener.h PRE-CREATION 
>   plugins/notifications/notificationslistener.cpp PRE-CREATION 
>   plugins/notifications/notificationsplugin.h 7cc67c5 
>   plugins/notifications/notificationsplugin.cpp badb5d3 
> 
> Diff: https://git.reviewboard.kde.org/r/125140/diff/
> 
> 
> Testing
> -------
> 
> I tested with my (patched) tablet, works fine.
> 
> 
> Thanks,
> 
> Holger Kaelberer
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdeconnect/attachments/20151126/9e2ef9d7/attachment.html>