Review Request 123593: [WIP] Refactored code to implement ssl and provide backward compatibility

[Vineet Garg]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123593/
-----------------------------------------------------------

(Updated May 26, 2015, 1:11 p.m.)


Review request for kdeconnect and Albert Vaca Cintora.


Changes
-------

* New approach, removed all pairing handler etc.
* Moved all RSA related stuff to new class named RsaHelper
* Set public key and private key in link itself, private key now resides in LanLink and LoopbackLink instead of BaseLink
* PublicKey still present in device, but only used during pairing

Future prospects :
* Ssl related stuff can be moved to SslHelper, like certificate management etc.
* No need of private key in SslLink
* Along with PublicKey, can use Certificate which will be embedded in pairing package if package comes through SslLink


Repository: kdeconnect-android


Description
-------

* Moved private key and public key from Device to Link
* Encrypt and decrypt functions moved from NetworkPackage class to LanLink class
* Added a new ParingHandler class so that each type of link can handle its own pairing process
* Added a field of "type" in device so that we can differentiate between devices based on types
* Now device need to send which type of link they will prefer in identity package, if nothing is send, the type is considered "normal". No change is done in createIdentityPackage now.

ISSUES
* SFTP plugin is not working now, because it uses public key from device which is not present now
* There is an instance of Public Key in pairing handler also, which needs to be removed, this instance is only used to save public key when pairing is done


Diffs (updated)
-----

  src/org/kde/kdeconnect/Backends/BaseLink.java 579a7af 
  src/org/kde/kdeconnect/Backends/LanBackend/LanLink.java 5994142 
  src/org/kde/kdeconnect/Backends/LanBackend/LanLinkProvider.java ae26958 
  src/org/kde/kdeconnect/Backends/LoopbackBackend/LoopbackLink.java add92f8 
  src/org/kde/kdeconnect/Backends/LoopbackBackend/LoopbackLinkProvider.java bd9c41b 
  src/org/kde/kdeconnect/BackgroundService.java 855a52d 
  src/org/kde/kdeconnect/Device.java 0d9d9b1 
  src/org/kde/kdeconnect/Helpers/SecurityHelper/RsaHelper.java PRE-CREATION 
  src/org/kde/kdeconnect/NetworkPackage.java e5a777e 
  src/org/kde/kdeconnect/Plugins/SftpPlugin/SftpImpl.java ec41060 

Diff: https://git.reviewboard.kde.org/r/123593/diff/


Testing
-------

Testing done with pairing and unpairing both pc and mobile, working fine
Tested using Ping plugin and Touchpad plugin, working fine.


Thanks,

Vineet Garg

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdeconnect/attachments/20150526/d6f49705/attachment.html>