Review Request 123637: Fix warning, don't use discouraged API

Albert Vaca Cintora albertvaka at gmail.com
Mon May 4 23:40:07 UTC 2015


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123637/#review79876
-----------------------------------------------------------

Ship it!


Awesome!

- Albert Vaca Cintora


On May 4, 2015, 4:22 p.m., Aleix Pol Gonzalez wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/123637/
> -----------------------------------------------------------
> 
> (Updated May 4, 2015, 4:22 p.m.)
> 
> 
> Review request for kdeconnect.
> 
> 
> Repository: kdeconnect-kde
> 
> 
> Description
> -------
> 
> We used to have the following warning: Connecting to deprecated signal QDBusConnectionInterface::serviceOwnerChanged(QString,QString,QString)
> 
> Port away from it as recommended in Qt documentation.
> 
> 
> Diffs
> -----
> 
>   plugins/mpriscontrol/mpriscontrolplugin.h 038f4b2 
>   plugins/mpriscontrol/mpriscontrolplugin.cpp 9dee951 
> 
> Diff: https://git.reviewboard.kde.org/r/123637/diff/
> 
> 
> Testing
> -------
> 
> Played around with VLC.
> 
> 
> Thanks,
> 
> Aleix Pol Gonzalez
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdeconnect/attachments/20150504/17d7adf1/attachment.html>


More information about the KDEConnect mailing list