Review Request 123325: Drop dependency of KIO from kdeconnectcore

[Albert Vaca Cintora]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123325/#review79873
-----------------------------------------------------------

Ship it!


Add some comments as we discussed over IM and push it!

- Albert Vaca Cintora


On May 4, 2015, 2:12 p.m., Aleix Pol Gonzalez wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/123325/
> -----------------------------------------------------------
> 
> (Updated May 4, 2015, 2:12 p.m.)
> 
> 
> Review request for kdeconnect.
> 
> 
> Repository: kdeconnect-kde
> 
> 
> Description
> -------
> 
> Use QNetworkAccessManager for storing the files we receive instead of directly KIO, then provide the KIO-based QNetworkAccessManager from the daemon. This way we'll still get the KIO network-transparency, but the library only depenends on QtNetwork, which will be easier to get in some platforms.
> 
> After this change, we only depend on KConfig, KI18n and KCoreAddons, which are tier1 and really easy to work with on any platform.
> 
> 
> Diffs
> -----
> 
>   CMakeLists.txt dbaa039 
>   core/CMakeLists.txt f465959 
>   core/daemon.h a2e2cfc 
>   core/daemon.cpp a063589 
>   core/filetransferjob.h 973bd3a 
>   core/filetransferjob.cpp 27ed8e8 
>   daemon/CMakeLists.txt 852e779 
>   daemon/kdeconnectd.cpp c43bc9b 
> 
> Diff: https://git.reviewboard.kde.org/r/123325/diff/
> 
> 
> Testing
> -------
> 
> Works for me.
> Tested sending from my Android device to the laptop.
> 
> 
> Thanks,
> 
> Aleix Pol Gonzalez
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdeconnect/attachments/20150504/a8085f66/attachment.html>