Review Request 123076: Remove KNotifications dependency from libkdeconnectcore

[Aleix Pol Gonzalez]

> On March 20, 2015, 7:11 p.m., Albert Vaca Cintora wrote:
> > core/daemon.cpp, line 39
> > <https://git.reviewboard.kde.org/r/123076/diff/1/?file=355840#file355840line39>
> >
> >     Why global instead of local static in Daemon or DaemonPrivate? If I remember correctly, this won't let somebody define another global called s_instance in, for example, kdeconnectd.

It won't prevent. Q_GLOBAL_STATIC is slightly better as it uses atomic in the implementation. See QGlobalStatic documentation.


> On March 20, 2015, 7:11 p.m., Albert Vaca Cintora wrote:
> > core/device.cpp, line 510
> > <https://git.reviewboard.kde.org/r/123076/diff/1/?file=355842#file355842line510>
> >
> >     What's wrong with static cast that you always avoid it? We know it's a Daemon for sure in this case (and we can still check it in debug with a QASSERT, if you want).

I can change that, I don't mind.

In fact, we maybe want to use the singleton here as well. This way we don't tie it to Daemon.


- Aleix


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123076/#review77846
-----------------------------------------------------------


On March 20, 2015, 1:28 a.m., Aleix Pol Gonzalez wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/123076/
> -----------------------------------------------------------
> 
> (Updated March 20, 2015, 1:28 a.m.)
> 
> 
> Review request for kdeconnect.
> 
> 
> Repository: kdeconnect-kde
> 
> 
> Description
> -------
> 
> Moves the implementation into the actual daemon. This opens the possibility for different ways to expose these notifications depending on where the libkdeconnect will be deployed.
> 
> 
> Diffs
> -----
> 
>   core/CMakeLists.txt 2026317 
>   core/daemon.h 1817bdf 
>   core/daemon.cpp 4e9cec4 
>   core/device.h c2d743a 
>   core/device.cpp 96c62b5 
>   core/kdeconnectconfig.cpp 1356f43 
>   daemon/CMakeLists.txt 8847c32 
>   daemon/kdeconnectd.cpp cb7de79 
> 
> Diff: https://git.reviewboard.kde.org/r/123076/diff/
> 
> 
> Testing
> -------
> 
> I unpaired myself and paired back.
> 
> 
> Thanks,
> 
> Aleix Pol Gonzalez
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdeconnect/attachments/20150320/38253127/attachment.html>