Review Request 123076: Remove KNotifications dependency from libkdeconnectcore

Aleix Pol Gonzalez aleixpol at kde.org
Fri Mar 20 00:28:30 UTC 2015


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123076/
-----------------------------------------------------------

Review request for kdeconnect.


Repository: kdeconnect-kde


Description
-------

Moves the implementation into the actual daemon. This opens the possibility for different ways to expose these notifications depending on where the libkdeconnect will be deployed.


Diffs
-----

  core/CMakeLists.txt 2026317 
  core/daemon.h 1817bdf 
  core/daemon.cpp 4e9cec4 
  core/device.h c2d743a 
  core/device.cpp 96c62b5 
  core/kdeconnectconfig.cpp 1356f43 
  daemon/CMakeLists.txt 8847c32 
  daemon/kdeconnectd.cpp cb7de79 

Diff: https://git.reviewboard.kde.org/r/123076/diff/


Testing
-------

I unpaired myself and paired back.


Thanks,

Aleix Pol Gonzalez

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdeconnect/attachments/20150320/c93392db/attachment.html>


More information about the KDEConnect mailing list