Review Request 122984: [kdeconnect] Make tests optional

[Albert Vaca Cintora]

> On mar. 16, 2015, 8:39 p.m., Albert Vaca Cintora wrote:
> > I've seen the discussion in the KIO package [1] and I have told my opinion there. I don't think we want the patch as it is now.
> > 
> > [1] https://git.reviewboard.kde.org/r/122206/
> 
> Andreas Sturmlechner wrote:
>     Thanks for your input! Actually what you describe is what I already had done for kdeconnect, only the kwin approach seemed to get more support even from those who were tendentially opposed to the idea. I would much prefer to get consensus on the matter.

At least for KDE Connect, please submit the "other version" of this patch. I don't see we having a consensus here :/ but at least let's try to implement it "the simple way" for most apps, unless their maintainers ask otherwise.


- Albert


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122984/#review77604
-----------------------------------------------------------


On mar. 16, 2015, 2:59 p.m., Andreas Sturmlechner wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/122984/
> -----------------------------------------------------------
> 
> (Updated mar. 16, 2015, 2:59 p.m.)
> 
> 
> Review request for kdeconnect.
> 
> 
> Repository: kdeconnect-kde
> 
> 
> Description
> -------
> 
> This patch makes it able to disable building tests by choice or unavailability of Qt5Test (by example of kwin).
> 
> 
> Diffs
> -----
> 
>   CMakeLists.txt b81a476a5fe749dcb22c2435747800cdede7c40e 
> 
> Diff: https://git.reviewboard.kde.org/r/122984/diff/
> 
> 
> Testing
> -------
> 
> Built with and without tests.
> 
> 
> Thanks,
> 
> Andreas Sturmlechner
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdeconnect/attachments/20150318/cc6b450a/attachment-0001.html>