Review Request 122936: Remove KConfig, KConfigGroup, KSharedConfig dependencies from KdeConnectConfig

[Albert Vaca Cintora]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122936/#review77542
-----------------------------------------------------------


I found two issues. I will fix them and commit it in your name.


core/kdeconnectconfig.cpp
<https://git.reviewboard.kde.org/r/122936/#comment53257>

    Missing endGroups



core/kdeconnectconfig.cpp
<https://git.reviewboard.kde.org/r/122936/#comment53258>

    Can be simplified to remove(deviceId);


- Albert Vaca Cintora


On mar. 14, 2015, 11:30 a.m., Ashish Bansal wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/122936/
> -----------------------------------------------------------
> 
> (Updated mar. 14, 2015, 11:30 a.m.)
> 
> 
> Review request for kdeconnect, Albert Vaca Cintora and Aleix Pol Gonzalez.
> 
> 
> Repository: kdeconnect-kde
> 
> 
> Description
> -------
> 
> Used QSettings instead of KConfig, KConfigGroup, KSharedConfig in KdeConnectConfig
> 
> 
> Diffs
> -----
> 
>   core/kdeconnectconfig.cpp fbe8eeb 
> 
> Diff: https://git.reviewboard.kde.org/r/122936/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Ashish Bansal
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdeconnect/attachments/20150316/44094d13/attachment.html>