Review Request 122925: Add functionality to Block/Unblock requests from device thus preventing spam condition.

[Albert Vaca Cintora]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122925/#review77470
-----------------------------------------------------------


As shown in the comments here, there are many ways to implement this, and I'm not sure which one is the right to implement, or how (for example, if we go for not replying to identity packets, maybe we should do that by default and only reply if we are in "discoverable" mode, like Bluetooth does). So, for now I would hold this patch until we actually encounter the problem we need to solve (as of now, paring request spam is not a big concern) and have a proper discussion about it.

- Albert Vaca Cintora


On March 14, 2015, 4:44 p.m., Ashish Bansal wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/122925/
> -----------------------------------------------------------
> 
> (Updated March 14, 2015, 4:44 p.m.)
> 
> 
> Review request for kdeconnect, Albert Vaca Cintora and Aleix Pol Gonzalez.
> 
> 
> Bugs: 336726
>     http://bugs.kde.org/show_bug.cgi?id=336726
> 
> 
> Repository: kdeconnect-kde
> 
> 
> Description
> -------
> 
> This stores the IP Address of the respective host into the Device Class and checks if it in the list of blocked devices stored into the kde connect configuration file.
> 
> 
> Diffs
> -----
> 
>   cli/kdeconnect-cli.cpp 70a894e 
>   core/backends/devicelink.h af1fe12 
>   core/backends/lan/landevicelink.h 7d31881 
>   core/backends/loopback/loopbackdevicelink.h 9d1ae14 
>   core/device.h ab57943 
>   core/device.cpp 67030ff 
>   core/kdeconnectconfig.h d1e721a 
>   core/kdeconnectconfig.cpp b165f4d 
> 
> Diff: https://git.reviewboard.kde.org/r/122925/diff/
> 
> 
> Testing
> -------
> 
> Tested but sometimes after unblocking the blocked devices, it takes some time to again show up pairing requests. I don't know why there is time delay!
> 
> 
> File Attachments
> ----------------
> 
> Corrected given issues and works well but needs #122936 merged
>   https://git.reviewboard.kde.org/media/uploaded/files/2015/03/14/a8842ef2-ed7f-472f-812d-9360ee26f187__block.diff
> 
> 
> Thanks,
> 
> Ashish Bansal
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdeconnect/attachments/20150314/f92ca1b7/attachment-0001.html>