Review Request 122925: Add functionality to Block/Unblock requests from device thus preventing spam condition.
Ashish Bansal
bansal.ashish096 at gmail.com
Sat Mar 14 15:44:48 UTC 2015
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122925/
-----------------------------------------------------------
(Updated March 14, 2015, 3:44 p.m.)
Review request for kdeconnect, Albert Vaca Cintora and Aleix Pol Gonzalez.
Bugs: 336726
http://bugs.kde.org/show_bug.cgi?id=336726
Repository: kdeconnect-kde
Description
-------
This stores the IP Address of the respective host into the Device Class and checks if it in the list of blocked devices stored into the kde connect configuration file.
Diffs
-----
cli/kdeconnect-cli.cpp 70a894e
core/backends/devicelink.h af1fe12
core/backends/lan/landevicelink.h 7d31881
core/backends/loopback/loopbackdevicelink.h 9d1ae14
core/device.h ab57943
core/device.cpp 67030ff
core/kdeconnectconfig.h d1e721a
core/kdeconnectconfig.cpp b165f4d
Diff: https://git.reviewboard.kde.org/r/122925/diff/
Testing
-------
Tested but sometimes after unblocking the blocked devices, it takes some time to again show up pairing requests. I don't know why there is time delay!
File Attachments (updated)
----------------
Corrected given issues and works well but needs #122936 merged
https://git.reviewboard.kde.org/media/uploaded/files/2015/03/14/a8842ef2-ed7f-472f-812d-9360ee26f187__block.diff
Thanks,
Ashish Bansal
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdeconnect/attachments/20150314/6c420d12/attachment.html>
More information about the KDEConnect
mailing list