Review Request 122925: Add functionality to Block/Unblock requests from device thus preventing spam condition.

[Vineet Garg]

> On March 14, 2015, 5:17 a.m., Albert Vaca Cintora wrote:
> > core/kdeconnectconfig.cpp, line 209
> > <https://git.reviewboard.kde.org/r/122925/diff/1/?file=354575#file354575line209>
> >
> >     Not every device will have a QHostAdress, blocking should be based only on the deviceId
> 
> Ashish Bansal wrote:
>     deviceId can be changed instantly in the NetworkPackage sent by the host device but not the IP Address. Spammer can create deviceId randomly and send pair network packages.
> 
> Albert Vaca Cintora wrote:
>     I agree, but take into account that this means that we have to move the block functionality to a lower level (inside the link itself), and change the approach completely.
> 
> Vineet Garg wrote:
>     Host address is not a reliable way to check a device, as in a network where DHCP is configured on router the host address may change with time. Like in my case the device which is first connected to router get address 192.168.1.2 and it increments with every new connection.

And as far as spamming is concerned, spammer can just send the packets with spoofed IP. Instead of this, we can use set discoverable, so that when device is not disoverable, it would not reply with its Identity Package.


- Vineet


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122925/#review77453
-----------------------------------------------------------


On March 12, 2015, 9:20 p.m., Ashish Bansal wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/122925/
> -----------------------------------------------------------
> 
> (Updated March 12, 2015, 9:20 p.m.)
> 
> 
> Review request for kdeconnect, Albert Vaca Cintora and Aleix Pol Gonzalez.
> 
> 
> Bugs: 336726
>     http://bugs.kde.org/show_bug.cgi?id=336726
> 
> 
> Repository: kdeconnect-kde
> 
> 
> Description
> -------
> 
> This stores the IP Address of the respective host into the Device Class and checks if it in the list of blocked devices stored into the kde connect configuration file.
> 
> 
> Diffs
> -----
> 
>   cli/kdeconnect-cli.cpp 70a894e 
>   core/backends/devicelink.h af1fe12 
>   core/backends/lan/landevicelink.h 7d31881 
>   core/backends/loopback/loopbackdevicelink.h 9d1ae14 
>   core/device.h ab57943 
>   core/device.cpp 67030ff 
>   core/kdeconnectconfig.h d1e721a 
>   core/kdeconnectconfig.cpp b165f4d 
> 
> Diff: https://git.reviewboard.kde.org/r/122925/diff/
> 
> 
> Testing
> -------
> 
> Tested but sometimes after unblocking the blocked devices, it takes some time to again show up pairing requests. I don't know why there is time delay!
> 
> 
> Thanks,
> 
> Ashish Bansal
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdeconnect/attachments/20150314/6d1f73aa/attachment.html>