Review Request 122925: Add functionality to Block/Unblock requests from device thus preventing spam condition.

[Albert Vaca Cintora]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122925/#review77453
-----------------------------------------------------------



cli/kdeconnect-cli.cpp
<https://git.reviewboard.kde.org/r/122925/#comment53197>

    Add some feedback for the user when you block/unblock.



core/backends/devicelink.h
<https://git.reviewboard.kde.org/r/122925/#comment53192>

    We can't expose this in the DeviceLink abstraction: not every implementation will rely on internet addresses



core/device.h
<https://git.reviewboard.kde.org/r/122925/#comment53196>

    An abstract device shouldn't contain an internet address: not every implementation will use IP.



core/device.cpp
<https://git.reviewboard.kde.org/r/122925/#comment53195>

    You are making a copy of a QStringList every time this is called. Why not simply using a isDeviceBlocked() function for that?



core/kdeconnectconfig.cpp
<https://git.reviewboard.kde.org/r/122925/#comment53193>

    Please update to use the new KdeConnectSettings instead of KConfig.



core/kdeconnectconfig.cpp
<https://git.reviewboard.kde.org/r/122925/#comment53194>

    Not every device will have a QHostAdress, blocking should be based only on the deviceId


- Albert Vaca Cintora


On mar. 12, 2015, 10:20 p.m., Ashish Bansal wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/122925/
> -----------------------------------------------------------
> 
> (Updated mar. 12, 2015, 10:20 p.m.)
> 
> 
> Review request for kdeconnect, Albert Vaca Cintora and Aleix Pol Gonzalez.
> 
> 
> Bugs: 336726
>     http://bugs.kde.org/show_bug.cgi?id=336726
> 
> 
> Repository: kdeconnect-kde
> 
> 
> Description
> -------
> 
> This stores the IP Address of the respective host into the Device Class and checks if it in the list of blocked devices stored into the kde connect configuration file.
> 
> 
> Diffs
> -----
> 
>   cli/kdeconnect-cli.cpp 70a894e 
>   core/backends/devicelink.h af1fe12 
>   core/backends/lan/landevicelink.h 7d31881 
>   core/backends/loopback/loopbackdevicelink.h 9d1ae14 
>   core/device.h ab57943 
>   core/device.cpp 67030ff 
>   core/kdeconnectconfig.h d1e721a 
>   core/kdeconnectconfig.cpp b165f4d 
> 
> Diff: https://git.reviewboard.kde.org/r/122925/diff/
> 
> 
> Testing
> -------
> 
> Tested but sometimes after unblocking the blocked devices, it takes some time to again show up pairing requests. I don't know why there is time delay!
> 
> 
> Thanks,
> 
> Ashish Bansal
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdeconnect/attachments/20150314/81a16d9c/attachment-0001.html>