Review Request 122912: Fix how the plasmoid status is specified

Aleix Pol Gonzalez aleixpol at kde.org
Fri Mar 13 00:00:14 UTC 2015



> On March 12, 2015, 8:56 p.m., Jonathan Riddell wrote:
> > This successfully does not show the icon when there is no pairing.  If I start plasma when there is a pairing it shows that there is a pairing.  But if I create a pairing then the icon doesn't appear, it remains hidden and the notification slideout says there is no pairing.

Sounds like a different issue.

I'll merge this in for now, you can show me what you're describing tomorrow, so we can come up with a patch.


- Aleix


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122912/#review77396
-----------------------------------------------------------


On March 12, 2015, 2:45 a.m., Aleix Pol Gonzalez wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/122912/
> -----------------------------------------------------------
> 
> (Updated March 12, 2015, 2:45 a.m.)
> 
> 
> Review request for kdeconnect and Jonathan Riddell.
> 
> 
> Repository: kdeconnect-kde
> 
> 
> Description
> -------
> 
> No need to show the FullRepresentation to figure out the status of the plasmoid.
> 
> Moves the code back to the main.qml file so that we're always tracking if there's actually paired devices.
> 
> 
> Diffs
> -----
> 
>   plasmoid/package/contents/ui/FullRepresentation.qml 98e2e03 
>   plasmoid/package/contents/ui/main.qml 71e66b1 
> 
> Diff: https://git.reviewboard.kde.org/r/122912/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Aleix Pol Gonzalez
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdeconnect/attachments/20150313/6c1ba51d/attachment-0001.html>


More information about the KDEConnect mailing list