Review Request 122813: Drop KIOWidgets dependency from KDEConnectCore

Aleix Pol Gonzalez aleixpol at kde.org
Mon Mar 9 12:30:45 UTC 2015


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122813/
-----------------------------------------------------------

(Updated March 9, 2015, 1:30 p.m.)


Status
------

This change has been marked as submitted.


Review request for kdeconnect.


Repository: kdeconnect-kde


Description
-------

Removes the usage of RenameDialog by moving the functionality away. In fact, what it does is make the share dialog try to come up with a different name rather than asking the user. It's a quite common procedure as makes the interaction simpler (for example, Chromium and Kamoso work like that).

The function "autoincFilename" was copied over from Kamoso (which copied over in turn from KSnapshot :D).


Diffs
-----

  core/CMakeLists.txt 95b8bd8 
  core/filetransferjob.h 8c94c99 
  core/filetransferjob.cpp 1e0dfcd 
  plugins/share/shareplugin.cpp 2c1566b 

Diff: https://git.reviewboard.kde.org/r/122813/diff/


Testing
-------


Thanks,

Aleix Pol Gonzalez

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdeconnect/attachments/20150309/f3c59f79/attachment.html>


More information about the KDEConnect mailing list