Review Request 122806: Now can add link for unpaired devices, latest commit was blocking it.

[Albert Vaca Cintora]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122806/#review77036
-----------------------------------------------------------

Ship it!


Ooops, good catch!

- Albert Vaca Cintora


On mar. 4, 2015, 1:39 p.m., Vineet Garg wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/122806/
> -----------------------------------------------------------
> 
> (Updated mar. 4, 2015, 1:39 p.m.)
> 
> 
> Review request for kdeconnect and Albert Vaca Cintora.
> 
> 
> Repository: kdeconnect-android
> 
> 
> Description
> -------
> 
> Commit for updating device name if changed was blocking links.add(link) for unpaired devices as public key was set to null for unpaired devices and its Base64 encoding was causing an exception.
> 
> 
> Diffs
> -----
> 
>   src/org/kde/kdeconnect/Device.java 547301c 
> 
> Diff: https://git.reviewboard.kde.org/r/122806/diff/
> 
> 
> Testing
> -------
> 
> Now works fine for both paired and unpaired devices.
> 
> 
> Thanks,
> 
> Vineet Garg
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdeconnect/attachments/20150305/8977841f/attachment.html>