Review Request 122813: Drop KIOWidgets dependency from KDEConnectCore

[Lucien Xu]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122813/#review77034
-----------------------------------------------------------


Looks good to me. Did not read the autoinc method, as I'm confident that it will work, since it got inherited from kamoso / ksnapshot ;)

- Lucien Xu


On mars 4, 2015, 10:38 après-midi, Aleix Pol Gonzalez wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/122813/
> -----------------------------------------------------------
> 
> (Updated mars 4, 2015, 10:38 après-midi)
> 
> 
> Review request for kdeconnect.
> 
> 
> Repository: kdeconnect-kde
> 
> 
> Description
> -------
> 
> Removes the usage of RenameDialog by moving the functionality away. In fact, what it does is make the share dialog try to come up with a different name rather than asking the user. It's a quite common procedure as makes the interaction simpler (for example, Chromium and Kamoso work like that).
> 
> The function "autoincFilename" was copied over from Kamoso (which copied over in turn from KSnapshot :D).
> 
> 
> Diffs
> -----
> 
>   core/CMakeLists.txt 95b8bd8 
>   core/filetransferjob.h 8c94c99 
>   core/filetransferjob.cpp 1e0dfcd 
>   plugins/share/shareplugin.cpp 2c1566b 
> 
> Diff: https://git.reviewboard.kde.org/r/122813/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Aleix Pol Gonzalez
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdeconnect/attachments/20150305/512a54de/attachment.html>