Review Request 124140: Ported over to Netty and added SSL support

[Vineet Garg]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124140/
-----------------------------------------------------------

(Updated June 30, 2015, 10:12 p.m.)


Review request for kdeconnect and Albert Vaca Cintora.


Changes
-------

* Fixed issues pointed out earlier
* Added manually build conscrypt from aosp source
* Added mips, x86, arm shared libraries for conscrypt
* Pairing splitted between device and link
* Link now has a timestamp to avoid concurrency issue (see comment in code)
* Added bouncycastle bcprov again, since it was used by mina sshd internally in old devices
* Added spongycastle bcpkix, instead of bouncycastle bcpkix due to class loader conflicts on old device
* Due to too much methods, multidex enabled

Testing Done
*
* Testing done on two Android physical devices with android version 4.2.1 and 5.0 with arm architecture
* 
* Testing done on emulator images with x86 and arm architecture

TODO
*
* Little bit code cleanup
* 
* Manual testing on old Android device
* 
* Testing on mips emulator image


Repository: kdeconnect-android


Description
-------

* Since MINA was tying hands in adding SSL, ported over Netty which has a good, clean and easy interface and a larger user and developer base.
* Added support to setup links on SSL
* Links automatically removed if wrong certificate is sent
* Shows keys based on hash of certificate to check right certificates are received
* Added a preference to use SSL, as it is experienced to cause high CPU usage on devices.
* Corrected unit tests, LanLinkProvider is removed as it is nearly impossible to write it with current design. Will find a way


Diffs (updated)
-----

  AndroidManifest.xml 0da70ba 
  build.gradle 6520c1c 
  libs/conscrypt.jar PRE-CREATION 
  libs/conscrypt.readme PRE-CREATION 
  libs/conscrypt_jni.jar PRE-CREATION 
  proguard-rules.pro ac9cda5 
  res/values/strings.xml c128342 
  src/org/kde/kdeconnect/Backends/BaseLink.java 579a7af 
  src/org/kde/kdeconnect/Backends/BaseLinkProvider.java cfaf621 
  src/org/kde/kdeconnect/Backends/BasePairingHandler.java PRE-CREATION 
  src/org/kde/kdeconnect/Backends/LanBackend/LanLink.java 5994142 
  src/org/kde/kdeconnect/Backends/LanBackend/LanLinkProvider.java ae26958 
  src/org/kde/kdeconnect/Backends/LanBackend/LanPairingHandler.java PRE-CREATION 
  src/org/kde/kdeconnect/Backends/LoopbackBackend/LoopbackLink.java add92f8 
  src/org/kde/kdeconnect/Backends/LoopbackBackend/LoopbackLinkProvider.java bd9c41b 
  src/org/kde/kdeconnect/Backends/LoopbackBackend/LoopbackPairingHandler.java PRE-CREATION 
  src/org/kde/kdeconnect/BackgroundService.java 5e3d8c2 
  src/org/kde/kdeconnect/Device.java 3262aef 
  src/org/kde/kdeconnect/Helpers/SecurityHelpers/RsaHelper.java PRE-CREATION 
  src/org/kde/kdeconnect/Helpers/SecurityHelpers/SslHelper.java PRE-CREATION 
  src/org/kde/kdeconnect/NetworkPackage.java f62b5d0 
  src/org/kde/kdeconnect/UserInterface/PairActivity.java 7a45751 
  tests/org/kde/kdeconnect/DeviceTest.java 5d3383d 
  tests/org/kde/kdeconnect/LanLinkProviderTest.java fe7863a 
  tests/org/kde/kdeconnect/LanLinkTest.java d3d94c9 
  tests/org/kde/kdeconnect/NetworkPackageTest.java a21114e 

Diff: https://git.reviewboard.kde.org/r/124140/diff/


Testing
-------

Tesed on some device with where both supports SSL, also with PC where ssl is not supported, working fine. Need a little bit more testing with more devices.


Thanks,

Vineet Garg

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdeconnect/attachments/20150630/97013278/attachment.html>