Review Request 124170: Make it possible to lock the screen from KDE Connect

[Aleix Pol Gonzalez]

> On June 25, 2015, 7:16 a.m., Albert Vaca Cintora wrote:
> > We have a plugin to inhibit the screen saver, I think it would make sense to merge them, and extend the plugin to manage the locking of the device. In a future we might add more stuff there, like automatically lock when your phone disconnects or unlock when it is connected, the same way we inhibit the locking right now.

Well, at the moment, the inhibit plugin is supposed to be disabled if you don't want the inhibition to happen (and note it's disabled by default). Also note it doesn't send or receive packages either. It's a special plugin.

The only similarity I see is that both are freedesktop services adopted.


- Aleix


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124170/#review81737
-----------------------------------------------------------


On June 25, 2015, 4:15 a.m., Aleix Pol Gonzalez wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/124170/
> -----------------------------------------------------------
> 
> (Updated June 25, 2015, 4:15 a.m.)
> 
> 
> Review request for kdeconnect.
> 
> 
> Repository: kdeconnect-kde
> 
> 
> Description
> -------
> 
> Connects to freedesktop ScreenSaver interface and un/locks it upon request.
> 
> 
> Diffs
> -----
> 
>   app/qml/main.qml 9b4cf82 
>   cli/kdeconnect-cli.cpp 3aa49e5 
>   interfaces/CMakeLists.txt 0220af8 
>   interfaces/dbusinterfaces.h 260a0e6 
>   interfaces/dbusinterfaces.cpp a89f7a0 
>   plasmoid/declarativeplugin/kdeconnectdeclarativeplugin.cpp 0db9e8b 
>   plugins/CMakeLists.txt 35aec66 
>   plugins/lockdevice/CMakeLists.txt PRE-CREATION 
>   plugins/lockdevice/kdeconnect_lockdevice.json PRE-CREATION 
>   plugins/lockdevice/lockdeviceplugin.h PRE-CREATION 
>   plugins/lockdevice/lockdeviceplugin.cpp PRE-CREATION 
>   plugins/lockdevice/org.freedesktop.ScreenSaver.xml PRE-CREATION 
> 
> Diff: https://git.reviewboard.kde.org/r/124170/diff/
> 
> 
> Testing
> -------
> 
> Locked my computer.
> 
> 
> Thanks,
> 
> Aleix Pol Gonzalez
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdeconnect/attachments/20150627/4663ff43/attachment.html>