Review Request 124183: Keep track of whether the daemon is alive

Albert Vaca Cintora albertvaka at gmail.com
Thu Jun 25 18:34:16 UTC 2015


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124183/#review81753
-----------------------------------------------------------

Ship it!


Cool, looks good. We should also make this change and implement add/remove events in the Notifications model as well: it had very similar code to the Devices model but we have only updated the last. Can you do it?

- Albert Vaca Cintora


On June 25, 2015, 11:25 a.m., Aleix Pol Gonzalez wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/124183/
> -----------------------------------------------------------
> 
> (Updated June 25, 2015, 11:25 a.m.)
> 
> 
> Review request for kdeconnect.
> 
> 
> Repository: kdeconnect-kde
> 
> 
> Description
> -------
> 
> Listen to dbus registrations. Remove all devices if the service dies, create all devices back when restored.
> 
> 
> Diffs
> -----
> 
>   interfaces/devicesmodel.cpp 6e41699 
> 
> Diff: https://git.reviewboard.kde.org/r/124183/diff/
> 
> 
> Testing
> -------
> 
> Not much yet, but I have it running.
> 
> 
> Thanks,
> 
> Aleix Pol Gonzalez
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdeconnect/attachments/20150625/63f1924e/attachment.html>


More information about the KDEConnect mailing list