Review Request 124158: Simplify Device::id management

[Aleix Pol Gonzalez]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124158/
-----------------------------------------------------------

(Updated June 24, 2015, 6:59 p.m.)


Status
------

This change has been marked as submitted.


Review request for kdeconnect.


Changes
-------

Submitted with commit 43451d6ae139f28a00948a00174832cf9d37f235 by Aleix Pol to branch master.


Repository: kdeconnect-kde


Description
-------

* Removes the id->row mapping. It was broken as the indices weren't updated when a row was added or removed.
* Stop exposing Device::id through dbus, just store it in the interface class.
    * It's redundant as it's part of the interface definition
    * If we keep it it will save us quite some dbus round-trips
    * It will be reliable, as nowadays id() sometimes QString() if the dbus connection is invalid.


Diffs
-----

  app/qml/main.qml ccde541 
  core/device.h f3c7797 
  interfaces/dbusinterfaces.h d551fba 
  interfaces/dbusinterfaces.cpp 69abbf7 
  interfaces/devicesmodel.h 92410ff 
  interfaces/devicesmodel.cpp ca854f3 

Diff: https://git.reviewboard.kde.org/r/124158/diff/


Testing
-------

Seems to work better.


Thanks,

Aleix Pol Gonzalez

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdeconnect/attachments/20150624/10620917/attachment-0001.html>