Review Request 123094: Add Bluetooth support for sending and receiving payloads. (KDE)

[Saikrishna Arcot]

> On June 21, 2015, 7:46 p.m., Aleix Pol Gonzalez wrote:
> > core/filetransferjob.cpp, line 155
> > <https://git.reviewboard.kde.org/r/123094/diff/6/?file=380920#file380920line155>
> >
> >     Why do you need this change? Seems unrelated to bluetooth anyway.

`mOrigin` is a pointer to a `QIODevice` object. The `disconnected()` signal doesn't exist in all implementations of `QIODevice`, and so if some object that doesn't have a `disconnected()` signal is passed in (like a `QBuffer`), then an error will occur here.

I think, in the original implementation, I passed in a `QBuffer`, and so had that problem. The current implementation passes in `QBluetoothSocket`, which does have a `disconnected()` signal. Do you want me to revert this change?


- Saikrishna


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123094/#review81632
-----------------------------------------------------------


On June 21, 2015, 7:40 p.m., Saikrishna Arcot wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/123094/
> -----------------------------------------------------------
> 
> (Updated June 21, 2015, 7:40 p.m.)
> 
> 
> Review request for kdeconnect.
> 
> 
> Repository: kdeconnect-kde
> 
> 
> Description
> -------
> 
> When sending a payload, a randomly-generated UUID is sent with the payload. The payload is sent on a separate Bluetooth connection through that UUID, with the sending device acting as the server and the receiving device acting as the receiver.
> 
> In addition, `core/filetransferjob.cpp` was edited to listen to the `aboutToClose()` signal instead of the `disconnected()` signal, which is guaranteed to exist on all implementations of `QIODevice`. I'm not sure of the side effects for the LAN device link.
> 
> 
> Diffs
> -----
> 
>   core/backends/bluetooth/CMakeLists.txt 125fa87a825b056395a8ce5ef0298665fd2e6293 
>   core/backends/bluetooth/bluetoothdevicelink.h 199d9ee4c6b89065154e82b6fcd2cea204c0ef31 
>   core/backends/bluetooth/bluetoothdevicelink.cpp e3c1e3335a312a2b9289a7806e6a4d9c9174c73c 
>   core/backends/bluetooth/bluetoothdownloadjob.h PRE-CREATION 
>   core/backends/bluetooth/bluetoothdownloadjob.cpp PRE-CREATION 
>   core/backends/bluetooth/bluetoothuploadjob.h PRE-CREATION 
>   core/backends/bluetooth/bluetoothuploadjob.cpp PRE-CREATION 
>   core/backends/devicelinereader.h a5255c77d95c13e5f806576bac2697fb4bc94708 
>   core/filetransferjob.cpp 66866906a6509ebb0ba00c1b48647c5807262120 
> 
> Diff: https://git.reviewboard.kde.org/r/123094/diff/
> 
> 
> Testing
> -------
> 
> KDE to Android: Works. Tested by sending a ~1 MB file.
> 
> Android to KDE: Mostly works. The file is transferred, but the transfer process doesn't consider itself "finished", despite the fact that the file is fully sent. Any ideas?
> 
> 
> Thanks,
> 
> Saikrishna Arcot
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdeconnect/attachments/20150622/67c085a5/attachment-0001.html>