Review Request 124145: Added current path to QUrl::fromUserInput for file sharing in kdeconnect-cli

Aleix Pol Gonzalez aleixpol at kde.org
Sun Jun 21 23:56:04 UTC 2015


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124145/#review81638
-----------------------------------------------------------



cli/kdeconnect-cli.cpp (line 108)
<https://git.reviewboard.kde.org/r/124145/#comment55945>

    QDir::currentPath is already the default. What we probably want is QUrl::AssumeLocalFile.


- Aleix Pol Gonzalez


On June 22, 2015, 12:05 a.m., Vineet Garg wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/124145/
> -----------------------------------------------------------
> 
> (Updated June 22, 2015, 12:05 a.m.)
> 
> 
> Review request for kdeconnect.
> 
> 
> Repository: kdeconnect-kde
> 
> 
> Description
> -------
> 
> kdeconnect-cli needed absolute path to share files, a relative path causes a link to be received with link content equals relative path. Now current path if also passed to QUrl::fromUserInput so that it automatically decodes relative path and if file does not exists, link is sent.
> 
> 
> Diffs
> -----
> 
>   cli/kdeconnect-cli.cpp d29b2bd 
> 
> Diff: https://git.reviewboard.kde.org/r/124145/diff/
> 
> 
> Testing
> -------
> 
> Works fine
> 
> 
> Thanks,
> 
> Vineet Garg
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdeconnect/attachments/20150621/c4ead923/attachment.html>


More information about the KDEConnect mailing list