Review Request 124120: Move the generation of dbus interfaces into interfaces/

[Albert Vaca Cintora]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124120/#review81547
-----------------------------------------------------------

Ship it!


Just one change: Remove the CMake macro "generate_and_install_dbus_interface" if we don't use it anymore, and move "geninterface" to that file, so that we can use it in more places (and easily copied over to other projects). You will need to add an extra parameter to "geninterface", to specify the sources variable to add the interface to.

- Albert Vaca Cintora


On June 17, 2015, 8:49 p.m., Aleix Pol Gonzalez wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/124120/
> -----------------------------------------------------------
> 
> (Updated June 17, 2015, 8:49 p.m.)
> 
> 
> Review request for kdeconnect.
> 
> 
> Repository: kdeconnect-kde
> 
> 
> Description
> -------
> 
> Simplifies the code altogether by centralizing the generation into 1 call that does all the steps.
> 
> 
> Diffs
> -----
> 
>   cmake/DbusInterfaceMacros.cmake 2c49753 
>   core/CMakeLists.txt 4d75251 
>   interfaces/CMakeLists.txt bae0cff 
>   plugins/battery/CMakeLists.txt cfb799a 
>   plugins/mprisremote/CMakeLists.txt 0392249 
>   plugins/notifications/CMakeLists.txt 233fae1 
>   plugins/sftp/CMakeLists.txt 7f68e0c 
> 
> Diff: https://git.reviewboard.kde.org/r/124120/diff/
> 
> 
> Testing
> -------
> 
> Just works.
> 
> 
> Thanks,
> 
> Aleix Pol Gonzalez
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdeconnect/attachments/20150618/dbb364e6/attachment.html>