Review Request 124079: Added LanLinkTest and LanLinkProviderTest

[Albert Vaca Cintora]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124079/#review81437
-----------------------------------------------------------

Ship it!



tests/org/kde/kdeconnect/LanLinkProviderTest.java (line 64)
<https://git.reviewboard.kde.org/r/124079/#comment55809>

    The assertNotNull should not be placed inside the catch. In the catch you can just fail().



tests/org/kde/kdeconnect/LanLinkProviderTest.java (line 72)
<https://git.reviewboard.kde.org/r/124079/#comment55810>

    Idem.



tests/org/kde/kdeconnect/LanLinkTest.java (line 257)
<https://git.reviewboard.kde.org/r/124079/#comment55811>

    1 second is probably enough


- Albert Vaca Cintora


On June 12, 2015, 4:25 a.m., Vineet Garg wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/124079/
> -----------------------------------------------------------
> 
> (Updated June 12, 2015, 4:25 a.m.)
> 
> 
> Review request for kdeconnect and Albert Vaca Cintora.
> 
> 
> Repository: kdeconnect-android
> 
> 
> Description
> -------
> 
> Added tests for LanLink and LanLinkProvider.
> 
> 
> Diffs
> -----
> 
>   tests/org/kde/kdeconnect/LanLinkProviderTest.java PRE-CREATION 
>   tests/org/kde/kdeconnect/LanLinkTest.java PRE-CREATION 
> 
> Diff: https://git.reviewboard.kde.org/r/124079/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Vineet Garg
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdeconnect/attachments/20150613/b65762f0/attachment.html>