Review Request 124077: QML-ify stuff
Albert Vaca Cintora
albertvaka at gmail.com
Fri Jun 12 21:42:03 UTC 2015
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124077/#review81430
-----------------------------------------------------------
Ship it!
interfaces/dbusinterfaces.h (line 59)
<https://git.reviewboard.kde.org/r/124077/#comment55802>
Q_SIGNALS
- Albert Vaca Cintora
On June 11, 2015, 4:18 p.m., Aleix Pol Gonzalez wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/124077/
> -----------------------------------------------------------
>
> (Updated June 11, 2015, 4:18 p.m.)
>
>
> Review request for kdeconnect.
>
>
> Repository: kdeconnect-kde
>
>
> Description
> -------
>
> * Add API to call random public plugin methods
> * qdbusxml2cpp is not generating the Q_PROPERTY attribute. For now [1], add it ourselves by addding a proxy signal.
>
> Extra:
> * Remove unused function declaration
>
> [1] https://codereview.qt-project.org/#/c/101545/
>
>
> Diffs
> -----
>
> core/device.h 1512721
> interfaces/dbusinterfaces.h 8f49fe3
> interfaces/dbusinterfaces.cpp 141ef64
> kcm/kcm.cpp dc61e1d
>
> Diff: https://git.reviewboard.kde.org/r/124077/diff/
>
>
> Testing
> -------
>
> Can still send pings, both from QML and QtWidgets.
>
>
> Thanks,
>
> Aleix Pol Gonzalez
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdeconnect/attachments/20150612/b4800a0e/attachment.html>
More information about the KDEConnect
mailing list