Review Request 124067: Simplify QML access

[Albert Vaca Cintora]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124067/#review81376
-----------------------------------------------------------

Ship it!


Minor stuff.


core/device.h (line 126)
<https://git.reviewboard.kde.org/r/124067/#comment55750>

    Rename to pairStatusChanged(bool paired)



core/device.h 
<https://git.reviewboard.kde.org/r/124067/#comment55751>

    Add back



kcm/kcm.cpp (lines 250 - 254)
<https://git.reviewboard.kde.org/r/124067/#comment55753>

    Nice! :)


- Albert Vaca Cintora


On jun. 10, 2015, 11:31 p.m., Aleix Pol Gonzalez wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/124067/
> -----------------------------------------------------------
> 
> (Updated jun. 10, 2015, 11:31 p.m.)
> 
> 
> Review request for kdeconnect.
> 
> 
> Repository: kdeconnect-kde
> 
> 
> Description
> -------
> 
> * Move DevicesSortProxyModel into the interfaces, to be re-used.
> * Make Device::isPaired property notify-able.
> * Expose a couple of innocent roles in DevicesModel.
> 
> 
> Diffs
> -----
> 
>   core/device.h f1610c2 
>   core/device.cpp 264e78b 
>   interfaces/CMakeLists.txt eb72363 
>   interfaces/devicesmodel.h e8c1d9e 
>   interfaces/devicesmodel.cpp 90f0b5b 
>   interfaces/devicessortproxymodel.h PRE-CREATION 
>   interfaces/devicessortproxymodel.cpp PRE-CREATION 
>   kcm/CMakeLists.txt 568972b 
>   kcm/devicessortproxymodel.h 1b6249b 
>   kcm/devicessortproxymodel.cpp 02d02a6 
>   kcm/kcm.h 1c2b0da 
>   kcm/kcm.cpp cf422e3 
>   plasmoid/declarativeplugin/kdeconnectdeclarativeplugin.cpp 28892f9 
> 
> Diff: https://git.reviewboard.kde.org/r/124067/diff/
> 
> 
> Testing
> -------
> 
> Not much, so far.
> 
> 
> Thanks,
> 
> Aleix Pol Gonzalez
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdeconnect/attachments/20150611/1ae0fdb5/attachment.html>