Review Request 124044: Changed project structure to incorporate tests and added network package and device test

[Vineet Garg]

> On June 10, 2015, 6:16 a.m., Albert Vaca Cintora wrote:
> > tests/org/kde/kdeconnect/DeviceTest.java, lines 44-45
> > <https://git.reviewboard.kde.org/r/124044/diff/2-3/?file=379353#file379353line44>
> >
> >     What problems?

Problems getting cache directory for application. Actually its the problem with dexmaker, dexmaker is used because mockito has problems with dex environment as class files are packed in dex. Will correct the comment and merge it.
https://code.google.com/p/dexmaker/issues/detail?id=2


- Vineet


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124044/#review81354
-----------------------------------------------------------


On June 9, 2015, 7:33 p.m., Vineet Garg wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/124044/
> -----------------------------------------------------------
> 
> (Updated June 9, 2015, 7:33 p.m.)
> 
> 
> Review request for kdeconnect and Albert Vaca Cintora.
> 
> 
> Repository: kdeconnect-android
> 
> 
> Description
> -------
> 
> * Changed project structure to incorporate tests.
> * Directory 'src' has 3 sub-directories main(contains main app source), androidTest(contains source for tests that needs to be run on Android device, test(contains source for tests that can be run on local JVM, currently empty).
> * Written NetworkPackageTest based on NetworkPackageTest of kdeconnect-kde.
> * Written a basic DeviceTest, that tests functionality for Device class.
> 
> 
> Diffs
> -----
> 
>   build.gradle fd4dabe 
>   src/org/kde/kdeconnect/Device.java a8a25c7 
>   src/org/kde/kdeconnect/NetworkPackage.java e5a777e 
>   tests/org/kde/kdeconnect/DeviceTest.java PRE-CREATION 
>   tests/org/kde/kdeconnect/NetworkPackageTest.java PRE-CREATION 
> 
> Diff: https://git.reviewboard.kde.org/r/124044/diff/
> 
> 
> Testing
> -------
> 
> Application builds properly
> Tests run successfully
> 
> 
> Thanks,
> 
> Vineet Garg
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdeconnect/attachments/20150610/c10b59d2/attachment.html>