Review Request 124044: Changed project structure to incorporate tests and added network package and device test

[Vineet Garg]

> On June 8, 2015, 10:38 p.m., Albert Vaca Cintora wrote:
> > Instead of having /src/main (old "/src") and /src/androidTests, I would like to keep /src as it is, and add /androidTests to the root of the repo. Moving the sources doesn't only cause monstrous diffs in review board (as Aleix already saw), but also makes the git history more difficult to track and can create lots of conflicts for people with local changes when pulling this.

That was done according to struture used in src directory in new projects. Now changed and created a 'tests' directory in project root.


- Vineet


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124044/#review81325
-----------------------------------------------------------


On June 9, 2015, 9:01 a.m., Vineet Garg wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/124044/
> -----------------------------------------------------------
> 
> (Updated June 9, 2015, 9:01 a.m.)
> 
> 
> Review request for kdeconnect and Albert Vaca Cintora.
> 
> 
> Repository: kdeconnect-android
> 
> 
> Description
> -------
> 
> * Changed project structure to incorporate tests.
> * Directory 'src' has 3 sub-directories main(contains main app source), androidTest(contains source for tests that needs to be run on Android device, test(contains source for tests that can be run on local JVM, currently empty).
> * Written NetworkPackageTest based on NetworkPackageTest of kdeconnect-kde.
> * Written a basic DeviceTest, that tests functionality for Device class.
> 
> 
> Diffs
> -----
> 
>   build.gradle fd4dabe 
>   src/org/kde/kdeconnect/Device.java a8a25c7 
>   src/org/kde/kdeconnect/NetworkPackage.java e5a777e 
>   tests/org/kde/kdeconnect/DeviceTest.java PRE-CREATION 
>   tests/org/kde/kdeconnect/NetworkPackageTest.java PRE-CREATION 
> 
> Diff: https://git.reviewboard.kde.org/r/124044/diff/
> 
> 
> Testing
> -------
> 
> Application builds properly
> Tests run successfully
> 
> 
> Thanks,
> 
> Vineet Garg
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdeconnect/attachments/20150609/a2b4c250/attachment.html>