Review Request 124044: Changed project structure to incorporate tests and added network package and device test
Vineet Garg
grg.vineet at gmail.com
Mon Jun 8 16:28:08 UTC 2015
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124044/
-----------------------------------------------------------
Review request for kdeconnect and Albert Vaca Cintora.
Repository: kdeconnect-android
Description
-------
* Changed project structure to incorporate tests.
* Directory 'src' has 3 sub-directories main(contains main app source), androidTest(contains source for tests that needs to be run on Android device, test(contains source for tests that can be run on local JVM, currently empty).
* Written NetworkPackageTest based on NetworkPackageTest of kdeconnect-kde.
* Written a basic DeviceTest, that tests functionality for Device class.
Diffs
-----
build.gradle fd4dabe
src/androidTest/java/org/kde/kdeconnect/DeviceTest.java PRE-CREATION
src/androidTest/java/org/kde/kdeconnect/NetworkPackageTest.java PRE-CREATION
src/main/java/org/kde/kdeconnect/Backends/BaseLink.java PRE-CREATION
src/main/java/org/kde/kdeconnect/Backends/BaseLinkProvider.java PRE-CREATION
src/main/java/org/kde/kdeconnect/Backends/LanBackend/LanLink.java PRE-CREATION
src/main/java/org/kde/kdeconnect/Backends/LanBackend/LanLinkProvider.java PRE-CREATION
src/main/java/org/kde/kdeconnect/Backends/LoopbackBackend/LoopbackLink.java PRE-CREATION
src/main/java/org/kde/kdeconnect/Backends/LoopbackBackend/LoopbackLinkProvider.java PRE-CREATION
src/main/java/org/kde/kdeconnect/BackgroundService.java PRE-CREATION
src/main/java/org/kde/kdeconnect/Device.java PRE-CREATION
src/main/java/org/kde/kdeconnect/Helpers/AppsHelper.java PRE-CREATION
src/main/java/org/kde/kdeconnect/Helpers/ContactsHelper.java PRE-CREATION
src/main/java/org/kde/kdeconnect/Helpers/DeviceHelper.java PRE-CREATION
src/main/java/org/kde/kdeconnect/Helpers/FilesHelper.java PRE-CREATION
src/main/java/org/kde/kdeconnect/Helpers/ImagesHelper.java PRE-CREATION
src/main/java/org/kde/kdeconnect/Helpers/NotificationsHelper.java PRE-CREATION
src/main/java/org/kde/kdeconnect/Helpers/StorageHelper.java PRE-CREATION
src/main/java/org/kde/kdeconnect/KdeConnectBroadcastReceiver.java PRE-CREATION
src/main/java/org/kde/kdeconnect/NetworkPackage.java PRE-CREATION
src/main/java/org/kde/kdeconnect/Plugins/BatteryPlugin/BatteryPlugin.java PRE-CREATION
src/main/java/org/kde/kdeconnect/Plugins/ClibpoardPlugin/ClipboardListener.java PRE-CREATION
src/main/java/org/kde/kdeconnect/Plugins/ClibpoardPlugin/ClipboardPlugin.java PRE-CREATION
src/main/java/org/kde/kdeconnect/Plugins/MousePadPlugin/KeyListenerView.java PRE-CREATION
src/main/java/org/kde/kdeconnect/Plugins/MousePadPlugin/MousePadActivity.java PRE-CREATION
src/main/java/org/kde/kdeconnect/Plugins/MousePadPlugin/MousePadGestureDetector.java PRE-CREATION
src/main/java/org/kde/kdeconnect/Plugins/MousePadPlugin/MousePadPlugin.java PRE-CREATION
src/main/java/org/kde/kdeconnect/Plugins/MprisPlugin/MprisActivity.java PRE-CREATION
src/main/java/org/kde/kdeconnect/Plugins/MprisPlugin/MprisPlugin.java PRE-CREATION
src/main/java/org/kde/kdeconnect/Plugins/NotificationsPlugin/AppDatabase.java PRE-CREATION
src/main/java/org/kde/kdeconnect/Plugins/NotificationsPlugin/NotificationFilterActivity.java PRE-CREATION
src/main/java/org/kde/kdeconnect/Plugins/NotificationsPlugin/NotificationReceiver.java PRE-CREATION
src/main/java/org/kde/kdeconnect/Plugins/NotificationsPlugin/NotificationsPlugin.java PRE-CREATION
src/main/java/org/kde/kdeconnect/Plugins/PingPlugin/PingPlugin.java PRE-CREATION
src/main/java/org/kde/kdeconnect/Plugins/Plugin.java PRE-CREATION
src/main/java/org/kde/kdeconnect/Plugins/PluginFactory.java PRE-CREATION
src/main/java/org/kde/kdeconnect/Plugins/SftpPlugin/SftpImpl.java PRE-CREATION
src/main/java/org/kde/kdeconnect/Plugins/SftpPlugin/SftpPlugin.java PRE-CREATION
src/main/java/org/kde/kdeconnect/Plugins/SharePlugin/ShareActivity.java PRE-CREATION
src/main/java/org/kde/kdeconnect/Plugins/SharePlugin/SharePlugin.java PRE-CREATION
src/main/java/org/kde/kdeconnect/Plugins/TelephonyPlugin/TelephonyPlugin.java PRE-CREATION
src/main/java/org/kde/kdeconnect/UserInterface/CustomDevicesActivity.java PRE-CREATION
src/main/java/org/kde/kdeconnect/UserInterface/DeviceActivity.java PRE-CREATION
src/main/java/org/kde/kdeconnect/UserInterface/List/ButtonItem.java PRE-CREATION
src/main/java/org/kde/kdeconnect/UserInterface/List/CustomItem.java PRE-CREATION
src/main/java/org/kde/kdeconnect/UserInterface/List/DeviceItem.java PRE-CREATION
src/main/java/org/kde/kdeconnect/UserInterface/List/EntryItem.java PRE-CREATION
src/main/java/org/kde/kdeconnect/UserInterface/List/ListAdapter.java PRE-CREATION
src/main/java/org/kde/kdeconnect/UserInterface/List/SectionItem.java PRE-CREATION
src/main/java/org/kde/kdeconnect/UserInterface/List/SmallEntryItem.java PRE-CREATION
src/main/java/org/kde/kdeconnect/UserInterface/List/TextItem.java PRE-CREATION
src/main/java/org/kde/kdeconnect/UserInterface/MainActivity.java PRE-CREATION
src/main/java/org/kde/kdeconnect/UserInterface/MainSettingsActivity.java PRE-CREATION
src/main/java/org/kde/kdeconnect/UserInterface/MaxWidthImageButton.java PRE-CREATION
src/main/java/org/kde/kdeconnect/UserInterface/PairActivity.java PRE-CREATION
src/main/java/org/kde/kdeconnect/UserInterface/PluginSettingsActivity.java PRE-CREATION
src/main/java/org/kde/kdeconnect/UserInterface/SettingsActivity.java PRE-CREATION
src/org/kde/kdeconnect/Backends/BaseLink.java 579a7af
src/org/kde/kdeconnect/Backends/BaseLinkProvider.java cfaf621
src/org/kde/kdeconnect/Backends/LanBackend/LanLink.java 5994142
src/org/kde/kdeconnect/Backends/LanBackend/LanLinkProvider.java ae26958
src/org/kde/kdeconnect/Backends/LoopbackBackend/LoopbackLink.java add92f8
src/org/kde/kdeconnect/Backends/LoopbackBackend/LoopbackLinkProvider.java bd9c41b
src/org/kde/kdeconnect/BackgroundService.java 5e3d8c2
src/org/kde/kdeconnect/Device.java a8a25c7
src/org/kde/kdeconnect/Helpers/AppsHelper.java 17883f3
src/org/kde/kdeconnect/Helpers/ContactsHelper.java 7569f6e
src/org/kde/kdeconnect/Helpers/DeviceHelper.java e9dd528
src/org/kde/kdeconnect/Helpers/FilesHelper.java b5347c9
src/org/kde/kdeconnect/Helpers/ImagesHelper.java ebe3ba5
src/org/kde/kdeconnect/Helpers/NotificationsHelper.java 6be50d8
src/org/kde/kdeconnect/Helpers/StorageHelper.java a2a992c
src/org/kde/kdeconnect/KdeConnectBroadcastReceiver.java e43afba
src/org/kde/kdeconnect/NetworkPackage.java e5a777e
src/org/kde/kdeconnect/Plugins/BatteryPlugin/BatteryPlugin.java ea03408
src/org/kde/kdeconnect/Plugins/ClibpoardPlugin/ClipboardListener.java 7f6601e
src/org/kde/kdeconnect/Plugins/ClibpoardPlugin/ClipboardPlugin.java de00305
src/org/kde/kdeconnect/Plugins/MousePadPlugin/KeyListenerView.java 1228fd5
src/org/kde/kdeconnect/Plugins/MousePadPlugin/MousePadActivity.java 322609d
src/org/kde/kdeconnect/Plugins/MousePadPlugin/MousePadGestureDetector.java fd8764f
src/org/kde/kdeconnect/Plugins/MousePadPlugin/MousePadPlugin.java f17bd31
src/org/kde/kdeconnect/Plugins/MprisPlugin/MprisActivity.java ccbd50f
src/org/kde/kdeconnect/Plugins/MprisPlugin/MprisPlugin.java ee110e4
src/org/kde/kdeconnect/Plugins/NotificationsPlugin/AppDatabase.java 45bc9ab
src/org/kde/kdeconnect/Plugins/NotificationsPlugin/NotificationFilterActivity.java 903a320
src/org/kde/kdeconnect/Plugins/NotificationsPlugin/NotificationReceiver.java 537412c
src/org/kde/kdeconnect/Plugins/NotificationsPlugin/NotificationsPlugin.java 03b9c62
src/org/kde/kdeconnect/Plugins/PingPlugin/PingPlugin.java 1b58e80
src/org/kde/kdeconnect/Plugins/Plugin.java 556e89d
src/org/kde/kdeconnect/Plugins/PluginFactory.java dcd1038
src/org/kde/kdeconnect/Plugins/SftpPlugin/SftpImpl.java ec41060
src/org/kde/kdeconnect/Plugins/SftpPlugin/SftpPlugin.java ecf5ca0
src/org/kde/kdeconnect/Plugins/SharePlugin/ShareActivity.java f409fda
src/org/kde/kdeconnect/Plugins/SharePlugin/SharePlugin.java 0d14cb1
src/org/kde/kdeconnect/Plugins/TelephonyPlugin/TelephonyPlugin.java f1e5ae2
src/org/kde/kdeconnect/UserInterface/CustomDevicesActivity.java acb5e63
src/org/kde/kdeconnect/UserInterface/DeviceActivity.java 88aa95c
src/org/kde/kdeconnect/UserInterface/List/ButtonItem.java a972b8f
src/org/kde/kdeconnect/UserInterface/List/CustomItem.java 927cac3
src/org/kde/kdeconnect/UserInterface/List/DeviceItem.java 247254b
src/org/kde/kdeconnect/UserInterface/List/EntryItem.java 2e3e91d
src/org/kde/kdeconnect/UserInterface/List/ListAdapter.java df26194
src/org/kde/kdeconnect/UserInterface/List/SectionItem.java a592b48
src/org/kde/kdeconnect/UserInterface/List/SmallEntryItem.java 2394fbe
src/org/kde/kdeconnect/UserInterface/List/TextItem.java 8848933
src/org/kde/kdeconnect/UserInterface/MainActivity.java a79d9c0
src/org/kde/kdeconnect/UserInterface/MainSettingsActivity.java cdfee7b
src/org/kde/kdeconnect/UserInterface/MaxWidthImageButton.java 7f97e58
src/org/kde/kdeconnect/UserInterface/PairActivity.java 7a45751
src/org/kde/kdeconnect/UserInterface/PluginSettingsActivity.java ba44e4f
src/org/kde/kdeconnect/UserInterface/SettingsActivity.java 06fd373
Diff: https://git.reviewboard.kde.org/r/124044/diff/
Testing
-------
Application builds properly
Tests run successfully
Thanks,
Vineet Garg
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdeconnect/attachments/20150608/c73f4185/attachment.html>
More information about the KDEConnect
mailing list