Review Request 124551: One Time Share - Enables to share files android to android without pairing devices

Ashish Bansal bansal.ashish096 at gmail.com
Fri Jul 31 13:58:19 UTC 2015


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124551/
-----------------------------------------------------------

Review request for kdeconnect, Àlex Fiestas, Albert Vaca Cintora, and Aleix Pol Gonzalez.


Repository: kdeconnect-android


Description
-------

Select file and click Share via KDE Connect and it will show you two sections, Share to Reachable and Share to Paired. Choose Share to Reachable and it'll show the notification to Accept/Reject file.


Diffs
-----

  AndroidManifest.xml 556b06b 
  res/layout/activity_main.xml 996dc57 
  res/layout/activity_one_time_receive.xml PRE-CREATION 
  res/values/strings.xml 6984ce6 
  src/org/kde/kdeconnect/Device.java 9fe583c 
  src/org/kde/kdeconnect/NetworkPackage.java e5a777e 
  src/org/kde/kdeconnect/Plugins/SharePlugin/OneTimeReceiveActivity.java PRE-CREATION 
  src/org/kde/kdeconnect/Plugins/SharePlugin/ShareActivity.java f409fda 
  src/org/kde/kdeconnect/Plugins/SharePlugin/SharePlugin.java 26c2773 
  src/org/kde/kdeconnect/Plugins/SharePlugin/TransferFile.java PRE-CREATION 

Diff: https://git.reviewboard.kde.org/r/124551/diff/


Testing
-------

Compiles fine. I had tested it earlier and I think it was working fine at that time but still I would say "it needs testing". It would be great if someone else could do that. Otherwise I'll test it soon in some days.


Thanks,

Ashish Bansal

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdeconnect/attachments/20150731/50de4016/attachment.html>


More information about the KDEConnect mailing list