Review Request 124419: [app] Setup KDeclarative before loading the Qml file

Aleix Pol Gonzalez aleixpol at kde.org
Wed Jul 22 14:26:35 UTC 2015


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124419/#review82809
-----------------------------------------------------------

Ship it!


Looks good.

I haven't seen any warnings because of that...?

- Aleix Pol Gonzalez


On July 22, 2015, 4:11 p.m., Martin Gräßlin wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/124419/
> -----------------------------------------------------------
> 
> (Updated July 22, 2015, 4:11 p.m.)
> 
> 
> Review request for kdeconnect and Aleix Pol Gonzalez.
> 
> 
> Repository: kdeconnect-kde
> 
> 
> Description
> -------
> 
> Otherwise methods injected into the engine by KDeclarative are not
> available in the loaded qml.
> 
> 
> Diffs
> -----
> 
>   app/main.cpp b23bf7055bad69d320aa42598df34d26d620af9d 
> 
> Diff: https://git.reviewboard.kde.org/r/124419/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Martin Gräßlin
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdeconnect/attachments/20150722/8871ac09/attachment.html>


More information about the KDEConnect mailing list