Review Request 124418: [app] Adjust application name to match desktop file

Aleix Pol Gonzalez aleixpol at kde.org
Wed Jul 22 13:54:11 UTC 2015


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124418/#review82806
-----------------------------------------------------------


Good stuff, is there a warning otherwise?

- Aleix Pol Gonzalez


On July 22, 2015, 3:20 p.m., Martin Gräßlin wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/124418/
> -----------------------------------------------------------
> 
> (Updated July 22, 2015, 3:20 p.m.)
> 
> 
> Review request for kdeconnect and Aleix Pol Gonzalez.
> 
> 
> Repository: kdeconnect-kde
> 
> 
> Description
> -------
> 
> The desktop file is called org.kde.kdeconnect.app - this needs to
> be respected in the application name. This is a requirement to match
> application windows to applications on Wayland. With a not-matching
> name the compositor is not able to show a window icon.
> 
> 
> Diffs
> -----
> 
>   app/main.cpp b23bf7055bad69d320aa42598df34d26d620af9d 
> 
> Diff: https://git.reviewboard.kde.org/r/124418/diff/
> 
> 
> Testing
> -------
> 
> Window icon shown in e.g. Present Windows. Requires https://codereview.qt-project.org/122045 - this bug made me find and fix a bug in QtWayland :-)
> 
> 
> Thanks,
> 
> Martin Gräßlin
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdeconnect/attachments/20150722/a32b754b/attachment-0001.html>


More information about the KDEConnect mailing list