Review Request 124417: [app] Add a title on the ApplicationWindow

Martin Gräßlin mgraesslin at kde.org
Wed Jul 22 13:49:35 UTC 2015


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124417/#review82805
-----------------------------------------------------------


[15:48] <apol> mgraesslin: drop Application, just i18n("KDE Connect"), then ship it
[15:48] <mgraesslin> all right

- Martin Gräßlin


On July 22, 2015, 3:16 p.m., Martin Gräßlin wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/124417/
> -----------------------------------------------------------
> 
> (Updated July 22, 2015, 3:16 p.m.)
> 
> 
> Review request for kdeconnect and Aleix Pol Gonzalez.
> 
> 
> Repository: kdeconnect-kde
> 
> 
> Description
> -------
> 
> Without a title, it's not possible to identify the window on Wayland.
> E.g. KWin doesn't have a title for the application in Present Windows
> or application switchers filtering it out.
> 
> 
> Diffs
> -----
> 
>   app/qml/main.qml 929a7f39dfae5c0859aef7810cfa186817216f52 
> 
> Diff: https://git.reviewboard.kde.org/r/124417/diff/
> 
> 
> Testing
> -------
> 
> 
> File Attachments
> ----------------
> 
> Present Windows with proper window title
>   https://git.reviewboard.kde.org/media/uploaded/files/2015/07/22/82f9a3f0-b99d-4120-94b1-cceec2b3ca09__view-large1.png
> 
> 
> Thanks,
> 
> Martin Gräßlin
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdeconnect/attachments/20150722/65d6bd26/attachment.html>


More information about the KDEConnect mailing list