Review Request 124312: Initial SSL implementation

[Vineet Garg]

> On July 11, 2015, midnight, Aleix Pol Gonzalez wrote:
> > core/backends/lan/downloadjob.cpp, line 46
> > <https://git.reviewboard.kde.org/r/124312/diff/1/?file=383915#file383915line46>
> >
> >     Why do we offer the option to not use SSL?

To add backward compatibility so that it can work with devices with protocol version 5. We can remove it in next release.


> On July 11, 2015, midnight, Aleix Pol Gonzalez wrote:
> > core/backends/lan/downloadjob.cpp, line 47
> > <https://git.reviewboard.kde.org/r/124312/diff/1/?file=383915#file383915line47>
> >
> >     useless debug info?

As I mentioned in description, these will be removed.


> On July 11, 2015, midnight, Aleix Pol Gonzalez wrote:
> > core/backends/linkprovider.h, line 38
> > <https://git.reviewboard.kde.org/r/124312/diff/1/?file=383928#file383928line38>
> >
> >     Move protected between public and private. Also, why is it there? To save the setter?

Had to use it from device class during pairing process.


> On July 11, 2015, midnight, Aleix Pol Gonzalez wrote:
> > core/device.cpp, line 213
> > <https://git.reviewboard.kde.org/r/124312/diff/1/?file=383934#file383934line213>
> >
> >     Why do we need to /try/ with all of the device links?

Since there will be one link per device per link provider, like one bluetooth link, one lan link. The idea is to pair for all the available links. As different links may rely on different attributes so these will be handled by their respective pairing handler. Also it we further want that if device is paired through one type of link, it should be automatically paired for another type upon connection.


- Vineet


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124312/#review82345
-----------------------------------------------------------


On July 9, 2015, 10:42 p.m., Vineet Garg wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/124312/
> -----------------------------------------------------------
> 
> (Updated July 9, 2015, 10:42 p.m.)
> 
> 
> Review request for kdeconnect.
> 
> 
> Repository: kdeconnect-kde
> 
> 
> Description
> -------
> 
> * Similar to Android version, this SSL implementation supports old version also.
> * Certificate is generated when public key is generated using QCA, but used as QSslCertificate because QSslSocket don't like QCA certificate.
> * A new server is written overriding QTcpServer for setting socket descriptor to QSslSocket.
> * QSslSocket works as plain socket to transfer identity package and then either uses encrypted mode or normal mode according to the received package.
> * If connetion is to be on SSL, new link is only added after successful handshake.
> * Certificate is embedded into identity package on start of encrypted mode and then set in device using it.
> * PairingHandler is added like in Android version so that each LinkProvider manage pairing according to its own rules.
> 
> P.S. : Uploaded the patch with some debug statements, will comment out them.
> 
> 
> Diffs
> -----
> 
>   core/CMakeLists.txt dd8fedb 
>   core/backends/lan/CMakeLists.txt 7c5be38 
>   core/backends/lan/downloadjob.h eeeab07 
>   core/backends/lan/downloadjob.cpp bba2e98 
>   core/backends/lan/landevicelink.h 7d31881 
>   core/backends/lan/landevicelink.cpp 0987057 
>   core/backends/lan/lanlinkprovider.h b379434 
>   core/backends/lan/lanlinkprovider.cpp f5d2b22 
>   core/backends/lan/lanpairinghandler.h PRE-CREATION 
>   core/backends/lan/lanpairinghandler.cpp PRE-CREATION 
>   core/backends/lan/server.h PRE-CREATION 
>   core/backends/lan/server.cpp PRE-CREATION 
>   core/backends/lan/socketlinereader.h b3be55a 
>   core/backends/lan/socketlinereader.cpp a6bd85e 
>   core/backends/lan/uploadjob.h 12b6f7e 
>   core/backends/lan/uploadjob.cpp b0d35fc 
>   core/backends/linkprovider.h f4fc309 
>   core/backends/pairinghandler.h PRE-CREATION 
>   core/backends/pairinghandler.cpp PRE-CREATION 
>   core/daemon.h 674ca01 
>   core/daemon.cpp af4c67b 
>   core/device.h 03f528c 
>   core/device.cpp c2dc609 
>   core/kdeconnectconfig.h af6c6df 
>   core/kdeconnectconfig.cpp 919505c 
>   core/networkpackage.h 6a0bf9c 
>   core/networkpackage.cpp 64cfab7 
>   plugins/sftp/kdeconnect_sftp.json 08a89fb 
>   tests/CMakeLists.txt b00a574 
>   tests/testsocketlinereader.cpp 77a9b4b 
> 
> Diff: https://git.reviewboard.kde.org/r/124312/diff/
> 
> 
> Testing
> -------
> 
> * Working fine, tested using connection to Android devices.
> * Pairing handler needs to be tested using two LinkProvider, working fine with one, but there be some problems with two LinkProviders simultaneouly.
> 
> 
> Thanks,
> 
> Vineet Garg
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdeconnect/attachments/20150713/c8c12d39/attachment-0001.html>