Review Request 124230: [mousepad] Use QX11Info to get the Display

[Aleix Pol Gonzalez]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124230/#review82000
-----------------------------------------------------------

Ship it!



plugins/mousepad/mousepadplugin.h (line 45)
<https://git.reviewboard.kde.org/r/124230/#comment56337>

    const bool


- Aleix Pol Gonzalez


On July 2, 2015, 2:55 p.m., Martin Gräßlin wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/124230/
> -----------------------------------------------------------
> 
> (Updated July 2, 2015, 2:55 p.m.)
> 
> 
> Review request for kdeconnect and Aleix Pol Gonzalez.
> 
> 
> Repository: kdeconnect-kde
> 
> 
> Description
> -------
> 
> Don't open a second Display, we can use the one used by Qt.
> Advantages are: we are on the correct Display, we don't open a Display
> connection on e.g. Wayland (it would succeed but not work as a connection
> to Xwayland would be opened) and we can drop the copy of fixx11h.
> 
> It's also a prerequisite to properly split the implementation to support
> Wayland in a later change.
> 
> 
> Diffs
> -----
> 
>   plugins/mousepad/CMakeLists.txt 823b54b8b19885e31f9af83c62d276cb316bedfa 
>   plugins/mousepad/fixx11h.h 8d69e156d44b0c74e5f0540b2b400c4268430237 
>   plugins/mousepad/mousepadplugin.h e8ce48028a253a3668871db2394400274b574c3d 
>   plugins/mousepad/mousepadplugin.cpp f49aa7f31da7e208c75b30243138dbbd50f3101c 
> 
> Diff: https://git.reviewboard.kde.org/r/124230/diff/
> 
> 
> Testing
> -------
> 
> compiles, extremely certain that it works without testing it.
> 
> 
> Thanks,
> 
> Martin Gräßlin
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdeconnect/attachments/20150702/5d57216d/attachment.html>