Review Request 124140: Ported over to Netty and added SSL support

[Vineet Garg]

> On July 1, 2015, 2:04 a.m., Albert Vaca Cintora wrote:
> > Searching about the SSL handshake error in Android 5.0 I found this bug report? https://code.google.com/p/android/issues/detail?id=88313
> > 
> > Have you tried the solution proposed here? It looks much better than adding a binary-compiled security Provider class. 
> > 
> > Also, what other options have you explored?

I never had this issue. The issue I had with Android L is https://code.google.com/p/android-developer-preview/issues/detail?id=1521, which was later fixed in Android 5.1 but still we had many devices with Android 5.0 out there.
The issue I was experiencing was high cpu and memory usage on devices with Android API level less than 20. I raised an issue in netty issues. If they will fix this, we will remove native dependencies. Although it is pointed out as Android bug, see issues below.
The cipher suite is not a problem, as I tested Android API level 17 connection with same API level, and issue persisted.
At best I found that security provider should be updated. It serves two main purposes, first of all solves all issues I had, also since security provider is patched time to time, older security providers might have vulnerabilities associated with them.

[1]https://github.com/netty/netty/issues/3904
[2]https://github.com/netty/netty/issues/3692
[3]https://github.com/netty/netty/issues/666


- Vineet


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124140/#review81922
-----------------------------------------------------------


On June 30, 2015, 10:12 p.m., Vineet Garg wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/124140/
> -----------------------------------------------------------
> 
> (Updated June 30, 2015, 10:12 p.m.)
> 
> 
> Review request for kdeconnect and Albert Vaca Cintora.
> 
> 
> Repository: kdeconnect-android
> 
> 
> Description
> -------
> 
> * Since MINA was tying hands in adding SSL, ported over Netty which has a good, clean and easy interface and a larger user and developer base.
> * Added support to setup links on SSL
> * Links automatically removed if wrong certificate is sent
> * Shows keys based on hash of certificate to check right certificates are received
> * Added a preference to use SSL, as it is experienced to cause high CPU usage on devices.
> * Corrected unit tests, LanLinkProvider is removed as it is nearly impossible to write it with current design. Will find a way
> 
> 
> Diffs
> -----
> 
>   AndroidManifest.xml 0da70ba 
>   build.gradle 6520c1c 
>   libs/conscrypt.jar PRE-CREATION 
>   libs/conscrypt.readme PRE-CREATION 
>   libs/conscrypt_jni.jar PRE-CREATION 
>   proguard-rules.pro ac9cda5 
>   res/values/strings.xml c128342 
>   src/org/kde/kdeconnect/Backends/BaseLink.java 579a7af 
>   src/org/kde/kdeconnect/Backends/BaseLinkProvider.java cfaf621 
>   src/org/kde/kdeconnect/Backends/BasePairingHandler.java PRE-CREATION 
>   src/org/kde/kdeconnect/Backends/LanBackend/LanLink.java 5994142 
>   src/org/kde/kdeconnect/Backends/LanBackend/LanLinkProvider.java ae26958 
>   src/org/kde/kdeconnect/Backends/LanBackend/LanPairingHandler.java PRE-CREATION 
>   src/org/kde/kdeconnect/Backends/LoopbackBackend/LoopbackLink.java add92f8 
>   src/org/kde/kdeconnect/Backends/LoopbackBackend/LoopbackLinkProvider.java bd9c41b 
>   src/org/kde/kdeconnect/Backends/LoopbackBackend/LoopbackPairingHandler.java PRE-CREATION 
>   src/org/kde/kdeconnect/BackgroundService.java 5e3d8c2 
>   src/org/kde/kdeconnect/Device.java 3262aef 
>   src/org/kde/kdeconnect/Helpers/SecurityHelpers/RsaHelper.java PRE-CREATION 
>   src/org/kde/kdeconnect/Helpers/SecurityHelpers/SslHelper.java PRE-CREATION 
>   src/org/kde/kdeconnect/NetworkPackage.java f62b5d0 
>   src/org/kde/kdeconnect/UserInterface/PairActivity.java 7a45751 
>   tests/org/kde/kdeconnect/DeviceTest.java 5d3383d 
>   tests/org/kde/kdeconnect/LanLinkProviderTest.java fe7863a 
>   tests/org/kde/kdeconnect/LanLinkTest.java d3d94c9 
>   tests/org/kde/kdeconnect/NetworkPackageTest.java a21114e 
> 
> Diff: https://git.reviewboard.kde.org/r/124140/diff/
> 
> 
> Testing
> -------
> 
> Tesed on some device with where both supports SSL, also with PC where ssl is not supported, working fine. Need a little bit more testing with more devices.
> 
> 
> Thanks,
> 
> Vineet Garg
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdeconnect/attachments/20150701/ae0391aa/attachment-0001.html>