Review Request 122221: Fix file transfer for Samsung Galaxy S2

Aleix Pol Gonzalez aleixpol at kde.org
Fri Jan 23 15:48:05 UTC 2015


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122221/#review74604
-----------------------------------------------------------



core/filetransferjob.cpp
<https://git.reviewboard.kde.org/r/122221/#comment51714>

    Maybe add a warning saying the url was wrong as well? This way we'll get to notice something was off.


- Aleix Pol Gonzalez


On Jan. 23, 2015, 3:49 p.m., Lamarque Souza wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/122221/
> -----------------------------------------------------------
> 
> (Updated Jan. 23, 2015, 3:49 p.m.)
> 
> 
> Review request for kdeconnect.
> 
> 
> Repository: kdeconnect-kde
> 
> 
> Description
> -------
> 
> My Samsung Galaxy S2 running Jelly Bean 4.1.2 was not able to send files to my computer. After tracking this problem down I figured out that kdeconnect's kded module receives a QUrl with an empty scheme. That QUrl is the file path to save, which in my case only works if I set scheme to "file".
> 
> 
> Diffs
> -----
> 
>   core/filetransferjob.cpp 98418ec 
> 
> Diff: https://git.reviewboard.kde.org/r/122221/diff/
> 
> 
> Testing
> -------
> 
> After this patch is applied kdeconnect's kded module is able to save the file being transfered. Without this patch, the file being saved is created empty and transfer's progress bar is stuck at 0%.
> 
> 
> Thanks,
> 
> Lamarque Souza
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdeconnect/attachments/20150123/4ec22b65/attachment.html>


More information about the KDEConnect mailing list