Review Request 122020: Make a bluetooth backend for Android

[Saikrishna Arcot]

> On Jan. 12, 2015, 8:33 p.m., Albert Vaca Cintora wrote:
> > Should I test it pairing a phone with another phone?
> 
> Saikrishna Arcot wrote:
>     Is that possible? If so, that would test much of the code.
> 
> Albert Vaca Cintora wrote:
>     Yes, it is :P You should try it!
> 
> Saikrishna Arcot wrote:
>     I would, but I only have 1 Android device. I'm working on the KDE backend so that I can test it here.

It appears that the Bluetooth classes were added in Qt 5.2, which means that the KDE backend can only be in the frameworks branch and will only work on KDE 5.

I'm currently not running KDE 5 (I'm hoping the Kubuntu Next PPA will get some KDE 5 applications), but will likely switch to it this weekend. Therefore, I'm working more on the Android side of things.


- Saikrishna


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122020/#review73888
-----------------------------------------------------------


On Jan. 16, 2015, 6:14 p.m., Saikrishna Arcot wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/122020/
> -----------------------------------------------------------
> 
> (Updated Jan. 16, 2015, 6:14 p.m.)
> 
> 
> Review request for kdeconnect.
> 
> 
> Repository: kdeconnect-android
> 
> 
> Description
> -------
> 
> (Note that this isn't ready for merging yet.)
> 
> This is an initial implementation of a bluetooth backend. This backend implementation can be run only on Android 4.0.2 or higher. The implementation as-is only looks at already-bonded devices; it does not start a discovery session to see other bluetooth devices nearby.
> 
> There are several things that need to be worked out.
> 
> 1. When requesting permission to enable Bluetooth (if it's not already enabled), `startActivityForResult` needs to be called. However, this must be called by a class that implements `Activity`. One possible solution is to call this on the home screen. Another is to just not request it.
> 2. I believe starting a discovery session also requires calling `startActivityForResult`, which has to be called from a class that implements `Activity`. The same solutions for the previous item exist here.
> 3. Options for enabling the Bluetooth backend need to be added to the settings window.
> 4. Some sections of code may warrant a new thread being created, as they may take a while to run.
> 
> 
> Diffs
> -----
> 
>   AndroidManifest.xml 6cbe4a7830cfe416fe98e42be143c0f26f2bf1e8 
>   src/org/kde/kdeconnect/Backends/BluetoothBackend/BluetoothLink.java PRE-CREATION 
>   src/org/kde/kdeconnect/Backends/BluetoothBackend/BluetoothLinkProvider.java PRE-CREATION 
>   src/org/kde/kdeconnect/BackgroundService.java 576425cf568e4b223d9840842803d7adabf6b990 
> 
> Diff: https://git.reviewboard.kde.org/r/122020/diff/
> 
> 
> Testing
> -------
> 
> Installed on my Android 4.1.2, and it correctly detected that there are 2 bonded devices. No crashes.
> 
> Note that since the KDE side doesn't have a bluetooth backend, much of the code wasn't executed.
> 
> 
> Thanks,
> 
> Saikrishna Arcot
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdeconnect/attachments/20150116/0ca56145/attachment-0001.html>