Review Request 121980: Added progress bar in notification while sending file.

[Vineet Garg]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/121980/
-----------------------------------------------------------

(Updated Jan. 15, 2015, 6:04 p.m.)


Review request for kdeconnect and Albert Vaca Cintora.


Changes
-------

* Changed data type of progress to long from int in Lanlink
* Changed some variable names for better understanding

* Added support to check for prevProgressPercentage when progress bar is shown for file downloads to decrease number of notifications pushed. Now smooth progress bar is shown in notification.


Repository: kdeconnect-android


Description
-------

Added progress bar in notification while sending file.

Current changes:
* Renamed SendPackageFinishedCallback -> SendPackageStatusCallback and added progressChanged to it.
* Made necessary changes so that the callback instance can reach to sendPayload for getting progress.
* Made changes in ShareToReceiver to show progress.


Diffs (updated)
-----

  res/values/strings.xml 23d10dc 
  src/org/kde/kdeconnect/Backends/BaseLink.java 242ff67 
  src/org/kde/kdeconnect/Backends/LanBackend/LanLink.java ca81c13 
  src/org/kde/kdeconnect/Backends/LanBackend/LanLinkProvider.java 19038bb 
  src/org/kde/kdeconnect/Backends/LoopbackBackend/LoopbackLink.java 0461cf1 
  src/org/kde/kdeconnect/Device.java b9a876b 
  src/org/kde/kdeconnect/Plugins/SharePlugin/SharePlugin.java 1e7e509 
  src/org/kde/kdeconnect/Plugins/SharePlugin/ShareToReceiver.java 170b7eb 

Diff: https://git.reviewboard.kde.org/r/121980/diff/


Testing
-------

Testing done for both file and content.

Current issues:
* sendSuccessful is called much before during file is being sent.
* Exception in onNotificationPosted due to early call of sendSuccessful.

Here is logcat output : http://pastebin.com/MvznkrAd


Thanks,

Vineet Garg

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdeconnect/attachments/20150115/7691ac62/attachment.html>