Review Request 121708: FindMyPhone plugin for KDE Connect

[Apoorv Parle]

> On Jan. 4, 2015, 9:15 a.m., Albert Vaca Cintora wrote:
> > I've been thinking about ways to implement this without requesting new permissions, and I think we could do it with some changes. If it's not absolutely necessary we should try to avoid adding new permisions. My idea is to just ring the phone without starting a new activity, and stop ringing when the user unlocks the phone or turns on the screen (ACTION_SCREEN_ON event). Do you like this approach?
> > 
> > Also, I would add a timer to stop ringing after 10 or 15 seconds even if you don't unlock it, just in case.

The whole intent of adding the wake lock permissions was because it is much easier to find the phone when its screen is turned on (especially in a dark room with only your laptop lights). That is why I added the wake lock permissions. Otherwise, yes I can explore this action and remove the wake lock. Let me know your thoughts...
In current case, the ringer will stop ringing automatically once the media file finishes. I suppose I can loop the media and add a stop duration. I think 15s is too short to search a phone in a house, maybe 30s ?


- Apoorv


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/121708/#review73053
-----------------------------------------------------------


On Dec. 28, 2014, 6:28 a.m., Apoorv Parle wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/121708/
> -----------------------------------------------------------
> 
> (Updated Dec. 28, 2014, 6:28 a.m.)
> 
> 
> Review request for kdeconnect and Albert Vaca Cintora.
> 
> 
> Repository: kdeconnect-android
> 
> 
> Description
> -------
> 
> * Uses Alarm Stream so that it is not affected by music player volumes and silent mode. Because alarm stream is used, if alarm stream volume is 0, no sound will be heard.
> * Chooses Alarm tone by default but falls back to ringtone if unavailable.
> * Additional activity to disable ringing once phone is found.
> * Extra wakelock permission required to display the activity above lockscreen.
> 
> Known Issues:
> * Speaker phone is not used if earphones are connected.
> 
> 
> Diffs
> -----
> 
>   res/layout/activity_findmyphone.xml PRE-CREATION 
>   AndroidManifest.xml 6cbe4a7830cfe416fe98e42be143c0f26f2bf1e8 
>   res/values/strings.xml 8d154b359edf2e2b082b51a8d0dbd2eae98a358c 
>   src/org/kde/kdeconnect/NetworkPackage.java 40f29c88ca14e042bd229331a47a02f2967a54f8 
>   src/org/kde/kdeconnect/Plugins/FindMyPhonePlugin/FindMyPhoneActivity.java PRE-CREATION 
>   src/org/kde/kdeconnect/Plugins/FindMyPhonePlugin/FindMyPhonePlugin.java PRE-CREATION 
>   src/org/kde/kdeconnect/Plugins/PluginFactory.java 6f51d1d9d138e6843948971052b5d665867a5ceb 
> 
> Diff: https://git.reviewboard.kde.org/r/121708/diff/
> 
> 
> Testing
> -------
> 
> All testing done on Android 4.4.4 device.
> * Tested behaviour with and without screen locked.
> * Tested behaviour with multiple ring requests.
> * Tested behaviour with all on-screen buttons.
> * Tested silent mode.
> 
> Not tested:
> * Behaviour when there is no default alarm tone set.
> 
> 
> Thanks,
> 
> Apoorv Parle
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdeconnect/attachments/20150104/cf5d04a1/attachment-0001.html>