Review Request 121742: (GCI) Added RemoteControlClient to MprisPlugin

Da-Jin Chu dajinchu at gmail.com
Thu Jan 1 04:29:53 UTC 2015


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/121742/
-----------------------------------------------------------

(Updated Jan. 1, 2015, 4:29 a.m.)


Review request for kdeconnect.


Changes
-------

Handled Stop, fixed commands, register once and no unregistering RemoteControlClient


Repository: kdeconnect-android


Description
-------

Task: https://www.google-melange.com/gci/task/view/google/gci2014/5841649192140800


Diffs (updated)
-----

  AndroidManifest.xml 6cbe4a7 
  src/org/kde/kdeconnect/Plugins/MprisPlugin/MprisActivity.java 22181ac 
  src/org/kde/kdeconnect/Plugins/MprisPlugin/MusicControlReceiver.java PRE-CREATION 
  src/org/kde/kdeconnect/Plugins/MprisPlugin/NotificationPanel.java 4d5fa5a 
  src/org/kde/kdeconnect/Plugins/MprisPlugin/NotificationReturnSlot.java 244eb55 
  src/org/kde/kdeconnect/Plugins/MprisPlugin/RemoteControlClientManager.java PRE-CREATION 

Diff: https://git.reviewboard.kde.org/r/121742/diff/


Testing
-------

Does not request AudioFocus, so the controls aren't available on lockscreen.
Proof that it works:

1. Plug in headphones that have play/pause button and click it.
2. Get https://play.google.com/store/apps/details?id=com.blackcrowsteam.musicstop&hl=en, play music from KDE-Connect, open "Music Stop" app, which will be able to stop the music.


Thanks,

Da-Jin Chu

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdeconnect/attachments/20150101/eb27313e/attachment.html>


More information about the KDEConnect mailing list