Review Request 122744: Simplify initialization of the private key

[Albert Vaca Cintora]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122744/#review76739
-----------------------------------------------------------


What do you mean with "Only 1 private key on the whole system, instead of one per service." If I understand correctly, before this change we had a single key per service (the device class was creating it the first time, but it was being reused from then on), and it doesn't look like your patch changes this.

The key-related crashes are happening because the key's path is stored in the config file, and it shouldn't: if the path changes (eg: when migrating from kdelibs4 to kf5) we will fail. You partially fixed this bug by adding a QFile::exists() check, but the best solution in my opinion would be to just not store the path in the config and assume that the key will be in a given location. If it's not there (ie: the first time or because paths have changed), we create a new one.

- Albert Vaca Cintora


On Feb. 27, 2015, 5:25 p.m., Aleix Pol Gonzalez wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/122744/
> -----------------------------------------------------------
> 
> (Updated Feb. 27, 2015, 5:25 p.m.)
> 
> 
> Review request for kdeconnect and Albert Vaca Cintora.
> 
> 
> Repository: kdeconnect-kde
> 
> 
> Description
> -------
> 
> First I saw it wasn't being found, I started digging, I solved this and a couple of other issues as well.
> - Only 1 private key on the whole system, instead of one per service.
> - Path specified only once rather than in daemon.cpp and device.cpp.
> 
> 
> Diffs
> -----
> 
>   core/device.h 2ebb403 
>   core/device.cpp e8412b7 
>   core/daemon.cpp 3688b4b 
> 
> Diff: https://git.reviewboard.kde.org/r/122744/diff/
> 
> 
> Testing
> -------
> 
> Now it doesn't keep crashing and getting restarted anymore.
> 
> 
> Thanks,
> 
> Aleix Pol Gonzalez
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdeconnect/attachments/20150227/05c3854a/attachment.html>