Feature Request

[Albert Vaca]

I haven't been able to test it yet, sorry. The only thing I noticed when I
checked the code review, is that it says that you changed "the background
and icon of the notification" but it doesn't seem to be anything in the
code for that. Did you forget to commit the interface xml files?

On Thu, Feb 12, 2015 at 4:43 AM, Chandramouleshwar S <mouli.4543 at gmail.com>
wrote:

> Hi...I made some changes in feature/noti-mediacontrol branch regarding
> aforementioned issues and submitted a patch. It would be great if someone
> reviews it suggest improvements as its not reviewed yet. I see a small bug
> in 'onConnectionLost' function and working on that now.
>
> On Thu, Feb 5, 2015 at 3:37 AM, Albert Vaca <albertvaka at gmail.com> wrote:
>
>> IMO we should implement both the old and the new APIs, because we don't
>> want to support only Android 5 devices. Nobody is working on this branch so
>> feel free to do the changes that you want. The issues that we found and
>> that made me decide to roll back the changes from the master branch are:
>> - The media player notification was never dismissed from the panel, even
>> if you stop the music player. So once it appeared it would keep showing
>> there until you kill kdeconnect.
>> - Other apps didn't see kdeconnect as a media player, so they couldn't
>> interact with it. Specifically, I have a pebble watch and I thought I
>> should be able to control kdeconnect through it, but that didn't work.
>> - The media player notification lost the reference to the media player
>> control plugin when the plugin was reloaded. This was specially notable
>> because there was a bug were plugins would be reloaded every time you
>> launch the kdeconnect app, even though this bug is now fixed in the master
>> branch (you might want to merge this branch back into the noti-mediacontrol
>> branch for this).
>>
>> Albert
>>
>>
>> On Wed, Feb 4, 2015 at 1:57 PM, Chandramouleshwar S <mouli.4543 at gmail.com
>> > wrote:
>>
>>> I checkedout that branch and the code want compiling. So i changed a
>>> line and compiled it succesfully. Can i know what are the issues with it
>>> and why is it not added to the master branch. I see that you are using
>>> RemoteControlClient to display notification on the lock screen. I saw that
>>> its deprecated in API 21. I would like to use the newer supported
>>> MediaSession and accomplish this. Is anyone working on it. I am new here,
>>> so it would be great if someone helps me in getting around.
>>>
>>> On Mon, Feb 2, 2015 at 9:47 PM, vineet garg <grgvineet at gmail.com> wrote:
>>>
>>>> Hi Chandramouleshwar,
>>>> That feature is already implemented by Da-Jin Chu but removed from master
>>>> branch due to some issues. You should check feature/noti-mediacontrol
>>>> branch.
>>>>
>>>> As there is always a room for improvement, so may be you could try that
>>>> .
>>>>
>>>> Vineet Garg
>>>>
>>>>
>>>> On Mon, Feb 2, 2015 at 9:28 PM, Chandramouleshwar S <
>>>> mouli.4543 at gmail.com> wrote:
>>>>
>>>>> I would like to add a notification tray that shows player controls
>>>>> when music is playing in kde( like how google play music shows play
>>>>> controls on notification try). Is somebody working on this right now?. If
>>>>> not, I wish to go on with the implementation.
>>>>>
>>>>> --
>>>>> With Peace,
>>>>> Chandramouleshwar S
>>>>>
>>>>>
>>>>> _______________________________________________
>>>>> KDEConnect mailing list
>>>>> KDEConnect at kde.org
>>>>> https://mail.kde.org/mailman/listinfo/kdeconnect
>>>>>
>>>>>
>>>>
>>>
>>>
>>> --
>>> With Peace,
>>> Chandramouleshwar S
>>>
>>>
>>> _______________________________________________
>>> KDEConnect mailing list
>>> KDEConnect at kde.org
>>> https://mail.kde.org/mailman/listinfo/kdeconnect
>>>
>>>
>>
>
>
> --
> With Peace,
> Chandramouleshwar S
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdeconnect/attachments/20150213/e74ff99a/attachment.html>