Review Request 125179: notifications: accept remote notifications

[Albert Vaca Cintora]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125179/#review89211
-----------------------------------------------------------

Ship it!



src/org/kde/kdeconnect/Plugins/NotificationsPlugin/NotificationsPlugin.java (line 332)
<https://git.reviewboard.kde.org/r/125179/#comment61033>

    I don't think we are checking this property in the NotificationsReceiver, so probably we should.


- Albert Vaca Cintora


On nov. 26, 2015, 1:50 p.m., Holger Kaelberer wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/125179/
> -----------------------------------------------------------
> 
> (Updated nov. 26, 2015, 1:50 p.m.)
> 
> 
> Review request for kdeconnect.
> 
> 
> Repository: kdeconnect-android
> 
> 
> Description
> -------
> 
> - request notifications onCreate
> - create (tagged) local notifications for remote notif
> - propagte cancellation to remote side when dismissed locally
> 
> This catches up with recent notifications changes on kdeconnect-master (https://git.reviewboard.kde.org/r/125140/). Handles only new OSes with API level > 17. Support for olders is coming ...
> 
> 
> Diffs
> -----
> 
>   src/org/kde/kdeconnect/Plugins/NotificationsPlugin/NotificationsPlugin.java efa37d1 
> 
> Diff: https://git.reviewboard.kde.org/r/125179/diff/
> 
> 
> Testing
> -------
> 
> Tested with tablet (api level 21) against desktop with patched master.
> 
> 
> Thanks,
> 
> Holger Kaelberer
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdeconnect/attachments/20151207/5132e305/attachment.html>