Review Request 125140: [kdeconnect-kde] initial support for desktop-to-XXX notifications

[Holger Kaelberer]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125140/
-----------------------------------------------------------

(Updated Dec. 4, 2015, 11:06 p.m.)


Review request for kdeconnect.


Changes
-------

- included review comments
- added a test-case for NotificationsListener


Repository: kdeconnect-kde


Description
-------

Eavesdrop on the Notify call of the org.freedesktop.Notifications dbus-interface, proxy all caught notifications to our peer device and track them in the internal notifications-list.

Also fix "cancel" requests from peer devices, by cutting of kdeconnect-android's id-prefix.


Diffs (updated)
-----

  core/kdeconnectpluginconfig.h 09bf68e 
  core/kdeconnectpluginconfig.cpp 980235c 
  plugins/notifications/CMakeLists.txt 41c5b78 
  plugins/notifications/kdeconnect_notifications_config.desktop PRE-CREATION 
  plugins/notifications/notifications_config.h PRE-CREATION 
  plugins/notifications/notifications_config.cpp PRE-CREATION 
  plugins/notifications/notifications_config.ui PRE-CREATION 
  plugins/notifications/notificationsdbusinterface.h 21d5a6a 
  plugins/notifications/notificationsdbusinterface.cpp 3c504c6 
  plugins/notifications/notificationslistener.h PRE-CREATION 
  plugins/notifications/notificationslistener.cpp PRE-CREATION 
  plugins/notifications/notificationsplugin.h 7cc67c5 
  plugins/notifications/notificationsplugin.cpp badb5d3 
  plugins/notifications/notifyingapplication.h PRE-CREATION 
  plugins/notifications/notifyingapplication.cpp PRE-CREATION 
  plugins/notifications/notifyingapplicationmodel.h PRE-CREATION 
  plugins/notifications/notifyingapplicationmodel.cpp PRE-CREATION 
  tests/CMakeLists.txt d585d2b 
  tests/testnotificationlistener.cpp PRE-CREATION 

Diff: https://git.reviewboard.kde.org/r/125140/diff/


Testing
-------

I tested with my (patched) tablet, works fine.


File Attachments
----------------

config screenshot 1
  https://git.reviewboard.kde.org/media/uploaded/files/2015/11/27/975e2005-2baa-4584-9bc4-dd406ebe2ae1__notifications-config0.jpg
config screeshot 2
  https://git.reviewboard.kde.org/media/uploaded/files/2015/11/27/09c97354-19ca-4606-81b8-61cdb3fa2af0__notifications-config1.jpg


Thanks,

Holger Kaelberer

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdeconnect/attachments/20151204/e05c4086/attachment.html>