Review Request 124551: One Time Share - Enables to share files android to android without pairing devices

[Ashish Bansal]

> On Aug. 28, 2015, 8:48 p.m., Albert Vaca Cintora wrote:
> > src/org/kde/kdeconnect/Plugins/SharePlugin/TransferFile.java, line 157
> > <https://git.reviewboard.kde.org/r/124551/diff/2/?file=399494#file399494line157>
> >
> >     "onetimeshare"? should be device name?
> 
> Ashish Bansal wrote:
>     Usually we will use this to get file from someone else's phone(to which we don't want to pair up). If I get files from multiple people, it's gonna create a lot of folders and I'll have to check/remember directory name whenever I have to find some file. So, we might do something like the bluetooth does.
>     
>     May be "onetimeshare" is not the good name for the folder. We can use better name or just keep it in "kdeconnect" instead of another subdirectory.

Ah, sorry! I should better go to sleep now.
Yeah it should be device name.


- Ashish


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124551/#review84550
-----------------------------------------------------------


On Aug. 28, 2015, 8:10 p.m., Ashish Bansal wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/124551/
> -----------------------------------------------------------
> 
> (Updated Aug. 28, 2015, 8:10 p.m.)
> 
> 
> Review request for kdeconnect, Àlex Fiestas, Albert Vaca Cintora, and Aleix Pol Gonzalez.
> 
> 
> Repository: kdeconnect-android
> 
> 
> Description
> -------
> 
> Select file and click Share via KDE Connect and it will show you two sections, Share to Reachable and Share to Paired. Choose Share to Reachable and it'll show the options to Accept/Reject file.
> 
> 
> Diffs
> -----
> 
>   AndroidManifest.xml 0da70ba 
>   res/layout/activity_one_time_receive.xml PRE-CREATION 
>   res/layout/activity_share.xml PRE-CREATION 
>   res/values/strings.xml c128342 
>   src/org/kde/kdeconnect/Plugins/SharePlugin/OneTimeReceiveActivity.java PRE-CREATION 
>   src/org/kde/kdeconnect/Plugins/SharePlugin/ShareActivity.java ab8154a 
>   src/org/kde/kdeconnect/Plugins/SharePlugin/SharePlugin.java 479c790 
>   src/org/kde/kdeconnect/Plugins/SharePlugin/TransferFile.java PRE-CREATION 
> 
> Diff: https://git.reviewboard.kde.org/r/124551/diff/
> 
> 
> Testing
> -------
> 
> NetworkPackage Payload gets lost due to which file is not received.
> 
> 
> Thanks,
> 
> Ashish Bansal
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdeconnect/attachments/20150828/41f648e0/attachment.html>